93 Commits
Author SHA1 Message Date
Quentin Bray 6ffa63b923 Apply R# clean-up for reliability (#877)
* Apply R# clean-up for reliability

- Migrate to NUnit4 Assert.That
- Update dependencise versions
- Fix LangVersion to 9.0 (until net core migration)
- Reformat code
- Apply 'var' style (easier for refactoring)
- Remove redundant parentheses
- Add braces on every condition blocks (1 line)
- Uses new null checking patterns
- Uses AutoProperties when possible
- Uses string scalar type instead of class
- Clean usings
- Add .orig files in git ignore
- Rename some properties to respect defined conventions and US format definition
	- ID -> Id
	- BPM -> Bpm
	- Finish -> End

* Update R# settings according to the clean-up made
2026-06-22 19:52:06 +02:00
Jiiniasu 68129ec451 Fix tone helper drawn on wrong octave (#746)
* Add GetCurrentBeat()

* Clamp tone helper to the octave of target note

Prevent tone helper from being off by an octave
2025-01-06 06:38:38 +01:00
Rap-VocaandFlorian Ostertag 451b97acbf Basic Rap Note Support (#708)
* Differentiate between Rap and Freestyle Notes

* Render Rap Notes

* Treat Rap notes as own notes

* Update CLyric.cs

---------

Co-authored-by: Florian Ostertag <flokuep@users.noreply.github.com>
2024-10-11 19:42:36 +02:00
Jiiniasu 8023b61a41 Fix delayed perfect line effect (#704)
* Fix delayed perfect line effect

* Address Sonarcloud issues for CNoteBars.cs

* Fix out of range bug caused by removing last()
2024-08-18 14:53:25 +02:00
Gary Kertopermono daec506445 Rap notes will use the rap notes graphics 2021-06-18 10:58:55 +02:00
Gary Kertopermono 821a85ab17 Made it easier to check for golden and rap notes 2020-04-05 18:03:27 +02:00
Gary Kertopermono 26655b84dc Rap notes are now properly interpreted 2019-04-09 17:32:42 +02:00
Florian Küpper 3f057cd1a6 Merge branch 'develop' into Multimonitor 2017-11-05 17:05:40 +01:00
Ilya Sosnovsky 7f2d7f576a Fix V3127
Two similar code fragments were found. Perhaps, this is a typo and 'Y' variable should be used instead of 'X' VocaluxeLib CSingNotes.cs 117
2017-10-31 14:39:00 +03:00
Jiiniasu 53d22b1082 Merge remote-tracking branch 'refs/remotes/Vocaluxe/develop' into Multimonitor
Modify CProgressBar to transfer properties to code-generated progressbars that does not exist in the screen xml
2017-09-23 15:28:25 +02:00
Florian Küpper d4545fd2b2 Merge branch 'develop' of github.com:Vocaluxe/Vocaluxe into develop 2017-09-11 12:35:29 +02:00
Jiiniasu e02ea84ff0 Merge remote-tracking branch 'refs/remotes/Vocaluxe/develop' into Multimonitor 2017-09-07 20:19:19 +02:00
Florian Küpper c5bfd46865 Removed outdated xml loading stuff 2017-09-02 18:00:06 +02:00
Jiiniasu e92bc0c13c Redo the 1-Pixel-Gap Fixes
A different approach to fix the 1px gaps occurring in certain notes.
2017-01-07 14:23:42 +01:00
Jiiniasu 25d98d5134 Fix: Positioning of Notelines
Notelines rect was top adjusted to a calculated center position making
the lines slightly offset downwards.
2017-01-07 12:01:23 +01:00
Jiiniasu 504d351cc2 Revert ScreenSing Version to 7 and Generate Elements in Code
To trim the fat off ScreenSing.xml the elements are now generated using
info for one screen as a base for the other screens.
2017-01-01 15:54:11 +01:00
Jiiniasu bf5205b080 Add Inital Multi-Monitor Support
Initial support for multimonitor setups.
Support for up to 6 monitors with 1-6 players on screen 1 and 0-6
players on screen 2-6.
Currently the max amount of players is unchanged and participating
players are spread across all available screens.

Screens are extended horizontally. For fullscreen use with multiple
physical monitors one will have to use some kind of
surround-configuration. (AMD Eyefinity/nVidia Surround/etc.)
2016-12-18 18:51:51 +01:00
Jiiniasu 9cf8126603 Fix 1px gap in middle of certain notes 2016-08-10 10:35:38 +02:00
Jiiniasu 01e1ead0a4 Fix 1px gap appearing in notes of certain lengths 2016-04-12 21:19:42 +02:00
Jiiniasu 989c7af2d2 Repeat note-mid-texture instead of stretching it
Additionally, the code no longer assumes width to be 2x end width.
2016-04-10 16:37:10 +02:00
Jiiniasu e3265edbb0 Make note base colorisable 2016-04-10 12:21:52 +02:00
Jiiniasu 4564c6a384 Correct broken fading and set fallback to use old hardcoded values 2016-04-10 11:02:18 +02:00
Jiiniasu a7a359c8e7 Make notelines colour customisable 2016-04-10 10:18:59 +02:00
Jiiniasu d9bc3fb907 Reorganising method arguments 2016-04-10 10:16:46 +02:00
Jiiniasu e1057f7c83 Commit changes in file missing from initial commit 2016-04-10 09:17:09 +02:00
Jiiniasu 639cb07fcf Make notes more customisable
Split notes graphics into note and fill
Changed notes, notes fill and notes bg to be the same size.
Distorting/stretching graphics no longer needed.
Adjusted the _DrawNote* functions and made additions for the separated
fill
2016-04-09 23:38:58 +02:00
Flamefire 4138470d6b Fix graphic glitches with sing notes 2014-12-17 21:06:06 +01:00
Flamefire cd59b82b7b Fix some resharper warnings and errors 2014-12-02 21:59:33 +01:00
Flamefire 4b0f563a6c Fix crashes/assertion failures on theme/skin change
First step of fixing theme saving (still needs some work)
2014-12-01 22:40:47 +01:00
Flamefire dd6b0416b6 Rename XML to lowercase Xml in classes and names for consistency 2014-11-17 19:33:48 +01:00
Flamefire 2f99cd2560 Make CSingNotes also implement Draw()
Also a bit refactoring
2014-10-22 22:00:25 +02:00
Flamefire d208f9d7b9 Reformatting
Also adds license headers
2014-10-19 18:51:14 +02:00
Flamefire ae7a7fd390 Implement a common Interface for all MenuElements
Also remove CSongMenu and replace it with a factory class
2014-10-19 17:17:39 +02:00
Flamefire 63fc406735 More unification of menuelements and fix for screensing theme 2014-10-18 20:46:51 +02:00
Flamefire d8cce13211 Rename LoadTextures to LoadSkin
(Its also Colors, not only textures!)
2014-10-18 10:42:35 +02:00
Flamefire 87f3271046 Remove copy constructors for structs 2014-10-16 21:38:22 +02:00
Flamefire 86fb73ca48 Cleanup not required XML attributes 2014-10-16 21:27:09 +02:00
Flamefire defb2ca6c7 Rewrite Theme Engine 2014-10-08 22:29:02 +02:00
Flamefire 9e5011374f Rename CTheme to CThemes 2014-10-05 17:27:45 +02:00
Flamefire 6ebbf7df6f Introduce example for a more flexible deserialization
Also make the CoverGenerator themes serializeable
Rest is automatic reformatting.
2014-10-01 00:54:04 +02:00
Flamefire c156fa69ab Merge branch 'develop' of git://github.com/flokuep/Vocaluxe into Better_Graphics_Handling
Conflicts:
	Vocaluxe/COSFunctions.cs
	VocaluxeLib/CHelper.cs
	VocaluxeLib/Menu/CStatic.cs
	VocaluxeLib/Structs.cs
2014-09-25 18:49:18 +02:00
Flamefire 926dda7350 Remove DrawLines (was not working in D3D and can actually be replaced by narrow DrawRects) 2014-09-24 18:54:58 +02:00
Flamefire 538eab9516 Add Assertions for color values and fix some wrong ones 2014-09-24 16:52:11 +02:00
Florian Küpper c07441bc63 Load complete theme-date with de-serialization. 2014-09-18 15:35:52 +02:00
Flamefire 7f8e974fe1 Rename CTexture to CTextureRef to reflect it is only a reference 2014-09-13 17:51:55 +02:00
Florian Küpper b2102b11d9 Add serialization for all theme-elements. 2014-08-26 16:48:30 +02:00
Alexander Eckart 4a7f7a3518 Bugfix: No perfect line flares 2013-12-22 23:18:17 +01:00
Flamefire 55d5c61a66 Fix overlapping notes
More consistent CLyric
Some renaming for clearer meaning
2013-10-11 14:50:27 +02:00
Flamefire 370964ee99 Fix file headers and indentations 2013-09-20 18:09:32 +02:00
Flamefire db9f04cad6 Some name refactoring for clearer meaning (also docu) 2013-09-20 17:57:34 +02:00