Remove ReloadSongMethod (#879)
Seems to not be usefull since song is cloned is others game mode Improve performance by stop reloading TXT file Didn't see any difference with and without instead of just song load perfs imrpovement Maybe that I miss a point ?
This commit is contained in:
1 parent
6ffa63b923
commit
cae67eb4ab
2 files changed
+2
-20
No files matched your search
@@ -1371,7 +1371,7 @@ namespace Vocaluxe.Screens
|
||||
_CloseSong();
|
||||
|
||||
CGame.ResetPlayer();
|
||||
_LoadCurrentSong(false);
|
||||
_LoadCurrentSong();
|
||||
|
||||
_StartSong();
|
||||
}
|
||||
@@ -1531,7 +1531,7 @@ namespace Vocaluxe.Screens
|
||||
/// <summary>
|
||||
/// Prepare streams and screen for current song.
|
||||
/// </summary>
|
||||
private void _LoadCurrentSong(bool reloadNotes = true)
|
||||
private void _LoadCurrentSong()
|
||||
{
|
||||
if (CGame.IsFinished())
|
||||
{
|
||||
@@ -1547,11 +1547,6 @@ namespace Vocaluxe.Screens
|
||||
return;
|
||||
}
|
||||
|
||||
if (!_Sso.Selection.PartyMode && (CGame.GameMode == EGameMode.TR_GAMEMODE_NORMAL || CGame.GameMode == EGameMode.TR_GAMEMODE_DUET))
|
||||
{
|
||||
song.ReloadSong(reloadNotes);
|
||||
}
|
||||
|
||||
var songname = song.Artist + " - " + song.Title;
|
||||
var rounds = CGame.GetNumSongs();
|
||||
if (rounds > 1)
|
||||
|
||||
@@ -305,19 +305,6 @@ namespace VocaluxeLib.Songs
|
||||
return loader.ReadNotes();
|
||||
}
|
||||
|
||||
public bool ReloadSong(bool reloadNotes)
|
||||
{
|
||||
var loader = new CSongLoader(this);
|
||||
var retValue = loader.ReadHeader();
|
||||
if (!retValue)
|
||||
{
|
||||
return false;
|
||||
}
|
||||
|
||||
retValue = loader.ReadNotes(reloadNotes);
|
||||
return retValue;
|
||||
}
|
||||
|
||||
public bool Save()
|
||||
{
|
||||
return Save(Path.Combine(Folder, FileName));
|
||||
|
||||
Reference in new issue
Block a user