mirror of
https://github.com/jmagar/unraid-mcp.git
synced 2026-03-02 00:04:45 -08:00
Comprehensive fixes across Python code, shell scripts, and documentation addressing all remaining MEDIUM and LOW priority review comments. Python Code Fixes (27 fixes): - tools/info.py: Simplified dispatch with lookup tables, defensive guards, CPU fallback formatting, !s conversion flags, module-level sync assertion - tools/docker.py: Case-insensitive container ID regex, keyword-only confirm, module-level ALL_ACTIONS constant - tools/virtualization.py: Normalized single-VM dict responses, unified list/details queries - core/client.py: Fixed HTTP client singleton race condition, compound key substring matching for sensitive data redaction - subscriptions/: Extracted SSL context creation to shared helper in utils.py, replaced deprecated ssl._create_unverified_context API - tools/array.py: Renamed parity_history to parity_status, hoisted ALL_ACTIONS - tools/storage.py: Fixed dict(None) risks, temperature 0 falsiness bug - tools/notifications.py, keys.py, rclone.py: Fixed dict(None) TypeError risks - tests/: Fixed generator type annotations, added coverage for compound keys Shell Script Fixes (13 fixes): - dashboard.sh: Dynamic server discovery, conditional debug output, null-safe jq, notification count guard order, removed unused variables - unraid-query.sh: Proper JSON escaping via jq, --ignore-errors and --insecure CLI flags, TLS verification now on by default - validate-marketplace.sh: Removed unused YELLOW variable, defensive jq, simplified repository URL output Documentation Fixes (24+ fixes): - Version consistency: Updated all references to v0.2.0 across pyproject.toml, plugin.json, marketplace.json, MARKETPLACE.md, __init__.py, README files - Tool count updates: Changed all "26 tools" references to "10 tools, 90 actions" - Markdown lint: Fixed MD022, MD031, MD047 issues across multiple files - Research docs: Fixed auth headers, removed web artifacts, corrected stale info - Skills docs: Fixed query examples, endpoint counts, env var references All 227 tests pass, ruff and ty checks clean.
52 lines
1.8 KiB
Python
52 lines
1.8 KiB
Python
"""Shared test fixtures and helpers for Unraid MCP server tests."""
|
|
|
|
from collections.abc import Generator
|
|
from typing import Any
|
|
from unittest.mock import AsyncMock, patch
|
|
|
|
import pytest
|
|
from fastmcp import FastMCP
|
|
|
|
|
|
@pytest.fixture
|
|
def mock_graphql_request() -> Generator[AsyncMock, None, None]:
|
|
"""Fixture that patches make_graphql_request at the core module.
|
|
|
|
NOTE: Since each tool file imports make_graphql_request into its own
|
|
namespace, tool-specific tests should patch at the tool module level
|
|
(e.g., "unraid_mcp.tools.info.make_graphql_request") instead of using
|
|
this fixture. This fixture is useful for testing the core client
|
|
or for integration tests that reload modules.
|
|
"""
|
|
with patch("unraid_mcp.core.client.make_graphql_request", new_callable=AsyncMock) as mock:
|
|
yield mock
|
|
|
|
|
|
def make_tool_fn(
|
|
module_path: str,
|
|
register_fn_name: str,
|
|
tool_name: str,
|
|
) -> Any:
|
|
"""Extract a tool function from a FastMCP registration for testing.
|
|
|
|
This wraps the repeated pattern of creating a test FastMCP instance,
|
|
registering a tool, and extracting the inner function. Centralizing
|
|
this avoids reliance on FastMCP's private `_tool_manager._tools` API
|
|
in every test file.
|
|
|
|
Args:
|
|
module_path: Dotted import path to the tool module (e.g., "unraid_mcp.tools.info")
|
|
register_fn_name: Name of the registration function (e.g., "register_info_tool")
|
|
tool_name: Name of the registered tool (e.g., "unraid_info")
|
|
|
|
Returns:
|
|
The async tool function callable
|
|
"""
|
|
import importlib
|
|
|
|
module = importlib.import_module(module_path)
|
|
register_fn = getattr(module, register_fn_name)
|
|
test_mcp = FastMCP("test")
|
|
register_fn(test_mcp)
|
|
return test_mcp._tool_manager._tools[tool_name].fn # type: ignore[union-attr]
|