mirror of
https://github.com/jmagar/unraid-mcp.git
synced 2026-03-23 04:29:17 -07:00
884319ab11
- guards.py: split confirm bypass into explicit check; use .get() for dict description to prevent KeyError on missing action keys - resources.py: use `is not None` for logs stream cache check; add on-demand subscribe_once fallback when auto_start is disabled so resources return real data instead of a perpetual "connecting" placeholder - setup.py: always prompt before overwriting credentials even on failed probe (transient outage ≠ bad credentials); update elicitation message - unraid.py: always elicit_reset_confirmation before overwriting creds; use asyncio.to_thread() for os.path.realpath() to avoid blocking async - test_health.py: update test for new always-prompt-on-overwrite behavior; add test for declined-reset on failed probe - test_resources.py: add tests for logs-stream None check, auto_start disabled fallback (success and failure), and fallback error recovery - test-tools.sh: add suite_live() covering cpu/memory/cpu_telemetry/ notifications_overview/log_tail; include in sequential and parallel runners - CLAUDE.md: correct unraid_live → live action reference; document that setup always prompts before overwriting; note subscribe_once fallback
111 lines
3.6 KiB
Python
111 lines
3.6 KiB
Python
"""Destructive action gating via MCP elicitation.
|
|
|
|
Provides gate_destructive_action() — a single call to guard any destructive
|
|
tool action with interactive user confirmation or confirm=True bypass.
|
|
"""
|
|
|
|
from typing import TYPE_CHECKING
|
|
|
|
from pydantic import BaseModel, Field
|
|
|
|
|
|
if TYPE_CHECKING:
|
|
from fastmcp import Context
|
|
|
|
from ..config.logging import logger
|
|
from .exceptions import ToolError
|
|
|
|
|
|
class _ConfirmAction(BaseModel):
|
|
confirmed: bool = Field(False, description="Check the box to confirm and proceed")
|
|
|
|
|
|
async def elicit_destructive_confirmation(
|
|
ctx: "Context | None", action: str, description: str
|
|
) -> bool:
|
|
"""Prompt the user to confirm a destructive action via MCP elicitation.
|
|
|
|
Args:
|
|
ctx: The MCP context. If None, returns False immediately.
|
|
action: Action name shown in the prompt.
|
|
description: Human-readable description of what the action will do.
|
|
|
|
Returns:
|
|
True if the user confirmed, False otherwise.
|
|
"""
|
|
if ctx is None:
|
|
logger.warning(
|
|
"Cannot elicit confirmation for '%s': no MCP context available. "
|
|
"Re-run with confirm=True to bypass elicitation.",
|
|
action,
|
|
)
|
|
return False
|
|
|
|
try:
|
|
result = await ctx.elicit(
|
|
message=(
|
|
f"**Confirm destructive action: `{action}`**\n\n"
|
|
f"{description}\n\n"
|
|
"Are you sure you want to proceed?"
|
|
),
|
|
response_type=_ConfirmAction,
|
|
)
|
|
except NotImplementedError:
|
|
logger.warning(
|
|
"MCP client does not support elicitation for action '%s'. "
|
|
"Re-run with confirm=True to bypass.",
|
|
action,
|
|
)
|
|
return False
|
|
|
|
if result.action != "accept":
|
|
logger.info("Destructive action '%s' declined by user (%s).", action, result.action)
|
|
return False
|
|
|
|
confirmed: bool = result.data.confirmed # type: ignore[union-attr]
|
|
if not confirmed:
|
|
logger.info("Destructive action '%s' not confirmed by user.", action)
|
|
return confirmed
|
|
|
|
|
|
async def gate_destructive_action(
|
|
ctx: "Context | None",
|
|
action: str,
|
|
destructive_actions: set[str],
|
|
confirm: bool,
|
|
description: str | dict[str, str],
|
|
) -> None:
|
|
"""Gate a destructive action with elicitation or confirm=True bypass.
|
|
|
|
Does nothing if the action is not in destructive_actions or confirm=True.
|
|
Otherwise calls elicit_destructive_confirmation; raises ToolError if the
|
|
user declines or elicitation is unavailable.
|
|
|
|
Args:
|
|
ctx: MCP context for elicitation (None skips elicitation).
|
|
action: The action being requested.
|
|
destructive_actions: Set of action names considered destructive.
|
|
confirm: When True, bypasses elicitation and proceeds immediately.
|
|
description: Human-readable description of the action's impact.
|
|
Pass a str when one description covers all destructive actions.
|
|
Pass a dict[action_name, description] when descriptions differ.
|
|
"""
|
|
if action not in destructive_actions:
|
|
return
|
|
|
|
if confirm:
|
|
logger.info("Destructive action '%s' bypassed via confirm=True.", action)
|
|
return
|
|
|
|
if isinstance(description, dict):
|
|
desc = description.get(action)
|
|
if desc is None:
|
|
raise ToolError(f"Missing destructive-action description for '{action}'.")
|
|
else:
|
|
desc = description
|
|
confirmed = await elicit_destructive_confirmation(ctx, action, desc)
|
|
if not confirmed:
|
|
raise ToolError(
|
|
f"Action '{action}' was not confirmed. Re-run with confirm=True to bypass elicitation."
|
|
)
|