mirror of
https://github.com/jmagar/unraid-mcp.git
synced 2026-03-02 00:04:45 -08:00
**Critical Fixes (7 issues):**
- Fix GraphQL schema field names in users tool (role→roles, remove email)
- Fix GraphQL mutation signatures (addUserInput, deleteUser input)
- Fix dict(None) TypeError guards in users tool (use `or {}` pattern)
- Fix FastAPI version constraint (0.116.1→0.115.0)
- Fix WebSocket SSL context handling (support CA bundles, bool, and None)
- Fix critical disk threshold treated as warning (split counters)
**High Priority Fixes (11 issues):**
- Fix Docker update/remove action response field mapping
- Fix path traversal vulnerability in log validation (normalize paths)
- Fix deleteApiKeys validation (check response before success)
- Fix rclone create_remote validation (check response)
- Fix keys input_data type annotation (dict[str, Any])
- Fix VM domain/domains fallback restoration
**Changes by file:**
- unraid_mcp/tools/docker.py: Response field mapping
- unraid_mcp/tools/info.py: Split critical/warning counters
- unraid_mcp/tools/storage.py: Path normalization for traversal protection
- unraid_mcp/tools/users.py: GraphQL schema + null handling
- unraid_mcp/tools/keys.py: Validation + type annotations
- unraid_mcp/tools/rclone.py: Response validation
- unraid_mcp/tools/virtualization.py: Domain fallback
- unraid_mcp/subscriptions/manager.py: SSL context creation
- pyproject.toml: FastAPI version fix
- tests/*: New tests for all fixes
**Review threads resolved:**
PRRT_kwDOO6Hdxs5uu70L, PRRT_kwDOO6Hdxs5uu70O, PRRT_kwDOO6Hdxs5uu70V,
PRRT_kwDOO6Hdxs5uu70e, PRRT_kwDOO6Hdxs5uu70i, PRRT_kwDOO6Hdxs5uu7zn,
PRRT_kwDOO6Hdxs5uu7z_, PRRT_kwDOO6Hdxs5uu7sI, PRRT_kwDOO6Hdxs5uu7sJ,
PRRT_kwDOO6Hdxs5uu7sK, PRRT_kwDOO6Hdxs5uu7Tk, PRRT_kwDOO6Hdxs5uu7Tn,
PRRT_kwDOO6Hdxs5uu7Tr, PRRT_kwDOO6Hdxs5uu7Ts, PRRT_kwDOO6Hdxs5uu7Tu,
PRRT_kwDOO6Hdxs5uu7Tv, PRRT_kwDOO6Hdxs5uu7Tw, PRRT_kwDOO6Hdxs5uu7Tx
All tests passing.
Co-authored-by: docker-fixer <agent@pr-fixes>
Co-authored-by: info-fixer <agent@pr-fixes>
Co-authored-by: storage-fixer <agent@pr-fixes>
Co-authored-by: users-fixer <agent@pr-fixes>
Co-authored-by: config-fixer <agent@pr-fixes>
Co-authored-by: websocket-fixer <agent@pr-fixes>
Co-authored-by: keys-rclone-fixer <agent@pr-fixes>
Co-authored-by: vm-fixer <agent@pr-fixes>
161 lines
5.4 KiB
Python
161 lines
5.4 KiB
Python
"""Virtual machine management.
|
|
|
|
Provides the `unraid_vm` tool with 9 actions for VM lifecycle management
|
|
including start, stop, pause, resume, force stop, reboot, and reset.
|
|
"""
|
|
|
|
from typing import Any, Literal
|
|
|
|
from fastmcp import FastMCP
|
|
|
|
from ..config.logging import logger
|
|
from ..core.client import make_graphql_request
|
|
from ..core.exceptions import ToolError
|
|
|
|
QUERIES: dict[str, str] = {
|
|
"list": """
|
|
query ListVMs {
|
|
vms { id domains { id name state uuid } }
|
|
}
|
|
""",
|
|
"details": """
|
|
query GetVmDetails {
|
|
vms { domains { id name state uuid } }
|
|
}
|
|
""",
|
|
}
|
|
|
|
MUTATIONS: dict[str, str] = {
|
|
"start": """
|
|
mutation StartVM($id: PrefixedID!) { vm { start(id: $id) } }
|
|
""",
|
|
"stop": """
|
|
mutation StopVM($id: PrefixedID!) { vm { stop(id: $id) } }
|
|
""",
|
|
"pause": """
|
|
mutation PauseVM($id: PrefixedID!) { vm { pause(id: $id) } }
|
|
""",
|
|
"resume": """
|
|
mutation ResumeVM($id: PrefixedID!) { vm { resume(id: $id) } }
|
|
""",
|
|
"force_stop": """
|
|
mutation ForceStopVM($id: PrefixedID!) { vm { forceStop(id: $id) } }
|
|
""",
|
|
"reboot": """
|
|
mutation RebootVM($id: PrefixedID!) { vm { reboot(id: $id) } }
|
|
""",
|
|
"reset": """
|
|
mutation ResetVM($id: PrefixedID!) { vm { reset(id: $id) } }
|
|
""",
|
|
}
|
|
|
|
# Map action names to their GraphQL field names
|
|
_MUTATION_FIELDS: dict[str, str] = {
|
|
"start": "start",
|
|
"stop": "stop",
|
|
"pause": "pause",
|
|
"resume": "resume",
|
|
"force_stop": "forceStop",
|
|
"reboot": "reboot",
|
|
"reset": "reset",
|
|
}
|
|
|
|
DESTRUCTIVE_ACTIONS = {"force_stop", "reset"}
|
|
|
|
VM_ACTIONS = Literal[
|
|
"list", "details",
|
|
"start", "stop", "pause", "resume", "force_stop", "reboot", "reset",
|
|
]
|
|
|
|
|
|
def register_vm_tool(mcp: FastMCP) -> None:
|
|
"""Register the unraid_vm tool with the FastMCP instance."""
|
|
|
|
@mcp.tool()
|
|
async def unraid_vm(
|
|
action: VM_ACTIONS,
|
|
vm_id: str | None = None,
|
|
confirm: bool = False,
|
|
) -> dict[str, Any]:
|
|
"""Manage Unraid virtual machines.
|
|
|
|
Actions:
|
|
list - List all VMs with state
|
|
details - Detailed info for a VM (requires vm_id: UUID, PrefixedID, or name)
|
|
start - Start a VM (requires vm_id)
|
|
stop - Gracefully stop a VM (requires vm_id)
|
|
pause - Pause a VM (requires vm_id)
|
|
resume - Resume a paused VM (requires vm_id)
|
|
force_stop - Force stop a VM (requires vm_id, confirm=True)
|
|
reboot - Reboot a VM (requires vm_id)
|
|
reset - Reset a VM (requires vm_id, confirm=True)
|
|
"""
|
|
all_actions = set(QUERIES) | set(MUTATIONS)
|
|
if action not in all_actions:
|
|
raise ToolError(f"Invalid action '{action}'. Must be one of: {sorted(all_actions)}")
|
|
|
|
if action != "list" and not vm_id:
|
|
raise ToolError(f"vm_id is required for '{action}' action")
|
|
|
|
if action in DESTRUCTIVE_ACTIONS and not confirm:
|
|
raise ToolError(f"Action '{action}' is destructive. Set confirm=True to proceed.")
|
|
|
|
try:
|
|
logger.info(f"Executing unraid_vm action={action}")
|
|
|
|
if action == "list":
|
|
data = await make_graphql_request(QUERIES["list"])
|
|
if data.get("vms"):
|
|
vms = data["vms"].get("domains") or data["vms"].get("domain")
|
|
if vms:
|
|
return {"vms": list(vms) if isinstance(vms, list) else []}
|
|
return {"vms": []}
|
|
|
|
if action == "details":
|
|
data = await make_graphql_request(QUERIES["details"])
|
|
if data.get("vms"):
|
|
vms = data["vms"].get("domains") or data["vms"].get("domain") or []
|
|
for vm in vms:
|
|
if (
|
|
vm.get("uuid") == vm_id
|
|
or vm.get("id") == vm_id
|
|
or vm.get("name") == vm_id
|
|
):
|
|
return dict(vm) if isinstance(vm, dict) else {}
|
|
available = [
|
|
f"{v.get('name')} (UUID: {v.get('uuid')})" for v in vms
|
|
]
|
|
raise ToolError(
|
|
f"VM '{vm_id}' not found. Available: {', '.join(available)}"
|
|
)
|
|
raise ToolError("No VM data returned from server")
|
|
|
|
# Mutations
|
|
if action in MUTATIONS:
|
|
data = await make_graphql_request(
|
|
MUTATIONS[action], {"id": vm_id}
|
|
)
|
|
field = _MUTATION_FIELDS[action]
|
|
if data.get("vm") and field in data["vm"]:
|
|
return {
|
|
"success": data["vm"][field],
|
|
"action": action,
|
|
"vm_id": vm_id,
|
|
}
|
|
raise ToolError(f"Failed to {action} VM or unexpected response")
|
|
|
|
raise ToolError(f"Unhandled action '{action}' — this is a bug")
|
|
|
|
except ToolError:
|
|
raise
|
|
except Exception as e:
|
|
logger.error(f"Error in unraid_vm action={action}: {e}", exc_info=True)
|
|
msg = str(e)
|
|
if "VMs are not available" in msg:
|
|
raise ToolError(
|
|
"VMs not available on this server. Check VM support is enabled."
|
|
) from e
|
|
raise ToolError(f"Failed to execute vm/{action}: {msg}") from e
|
|
|
|
logger.info("VM tool registered successfully")
|