mirror of
https://github.com/jmagar/unraid-mcp.git
synced 2026-03-02 08:14:43 -08:00
Addresses issues found by 4 parallel review agents (code-reviewer,
silent-failure-hunter, type-design-analyzer, pr-test-analyzer).
Source fixes:
- core/utils.py: add public safe_display_url() (moved from tools/health.py)
- core/client.py: rename _redact_sensitive → redact_sensitive (public API)
- core/types.py: add SubscriptionData.__post_init__ for tz-aware datetime
enforcement; remove 6 unused type aliases (SystemHealth, APIResponse, etc.)
- subscriptions/manager.py: add exc_info=True to both except-Exception blocks;
add except ValueError break-on-config-error before retry loop; import
redact_sensitive by new public name
- subscriptions/resources.py: re-raise in autostart_subscriptions() so
ensure_subscriptions_started() doesn't permanently set _subscriptions_started
- subscriptions/diagnostics.py: except ToolError: raise before broad except;
use safe_display_url() instead of raw URL slice
- tools/health.py: move _safe_display_url to core/utils; add exc_info=True;
raise ToolError (not return dict) on ImportError
- tools/info.py: use get_args(INFO_ACTIONS) instead of INFO_ACTIONS.__args__
- tools/{array,docker,keys,notifications,rclone,storage,virtualization}.py:
add Literal-vs-ALL_ACTIONS sync check at import time
Test fixes:
- test_health.py: import safe_display_url from core.utils; update
test_diagnose_import_error_internal to expect ToolError (not error dict)
- test_storage.py: add 3 safe_get tests for zero/False/empty-string values
- test_subscription_manager.py: add TestCapLogContentSingleMassiveLine (2 tests)
- test_client.py: rename _redact_sensitive → redact_sensitive; add tests for
new sensitive keys and is_cacheable explicit-keyword form
153 lines
5.2 KiB
Python
153 lines
5.2 KiB
Python
"""API key management.
|
|
|
|
Provides the `unraid_keys` tool with 5 actions for listing, viewing,
|
|
creating, updating, and deleting API keys.
|
|
"""
|
|
|
|
from typing import Any, Literal, get_args
|
|
|
|
from fastmcp import FastMCP
|
|
|
|
from ..config.logging import logger
|
|
from ..core.client import make_graphql_request
|
|
from ..core.exceptions import ToolError, tool_error_handler
|
|
|
|
|
|
QUERIES: dict[str, str] = {
|
|
"list": """
|
|
query ListApiKeys {
|
|
apiKeys { id name roles permissions createdAt lastUsed }
|
|
}
|
|
""",
|
|
"get": """
|
|
query GetApiKey($id: PrefixedID!) {
|
|
apiKey(id: $id) { id name roles permissions createdAt lastUsed }
|
|
}
|
|
""",
|
|
}
|
|
|
|
MUTATIONS: dict[str, str] = {
|
|
"create": """
|
|
mutation CreateApiKey($input: CreateApiKeyInput!) {
|
|
createApiKey(input: $input) { id name key roles }
|
|
}
|
|
""",
|
|
"update": """
|
|
mutation UpdateApiKey($input: UpdateApiKeyInput!) {
|
|
updateApiKey(input: $input) { id name roles }
|
|
}
|
|
""",
|
|
"delete": """
|
|
mutation DeleteApiKeys($input: DeleteApiKeysInput!) {
|
|
deleteApiKeys(input: $input)
|
|
}
|
|
""",
|
|
}
|
|
|
|
DESTRUCTIVE_ACTIONS = {"delete"}
|
|
ALL_ACTIONS = set(QUERIES) | set(MUTATIONS)
|
|
|
|
KEY_ACTIONS = Literal[
|
|
"list",
|
|
"get",
|
|
"create",
|
|
"update",
|
|
"delete",
|
|
]
|
|
|
|
if set(get_args(KEY_ACTIONS)) != ALL_ACTIONS:
|
|
_missing = ALL_ACTIONS - set(get_args(KEY_ACTIONS))
|
|
_extra = set(get_args(KEY_ACTIONS)) - ALL_ACTIONS
|
|
raise RuntimeError(
|
|
f"KEY_ACTIONS and ALL_ACTIONS are out of sync. "
|
|
f"Missing from Literal: {_missing or 'none'}. Extra in Literal: {_extra or 'none'}"
|
|
)
|
|
|
|
|
|
def register_keys_tool(mcp: FastMCP) -> None:
|
|
"""Register the unraid_keys tool with the FastMCP instance."""
|
|
|
|
@mcp.tool()
|
|
async def unraid_keys(
|
|
action: KEY_ACTIONS,
|
|
confirm: bool = False,
|
|
key_id: str | None = None,
|
|
name: str | None = None,
|
|
roles: list[str] | None = None,
|
|
permissions: list[str] | None = None,
|
|
) -> dict[str, Any]:
|
|
"""Manage Unraid API keys.
|
|
|
|
Actions:
|
|
list - List all API keys
|
|
get - Get a specific API key (requires key_id)
|
|
create - Create a new API key (requires name; optional roles, permissions)
|
|
update - Update an API key (requires key_id; optional name, roles)
|
|
delete - Delete API keys (requires key_id, confirm=True)
|
|
"""
|
|
if action not in ALL_ACTIONS:
|
|
raise ToolError(f"Invalid action '{action}'. Must be one of: {sorted(ALL_ACTIONS)}")
|
|
|
|
if action in DESTRUCTIVE_ACTIONS and not confirm:
|
|
raise ToolError(f"Action '{action}' is destructive. Set confirm=True to proceed.")
|
|
|
|
with tool_error_handler("keys", action, logger):
|
|
logger.info(f"Executing unraid_keys action={action}")
|
|
|
|
if action == "list":
|
|
data = await make_graphql_request(QUERIES["list"])
|
|
keys = data.get("apiKeys", [])
|
|
return {"keys": list(keys) if isinstance(keys, list) else []}
|
|
|
|
if action == "get":
|
|
if not key_id:
|
|
raise ToolError("key_id is required for 'get' action")
|
|
data = await make_graphql_request(QUERIES["get"], {"id": key_id})
|
|
return dict(data.get("apiKey") or {})
|
|
|
|
if action == "create":
|
|
if not name:
|
|
raise ToolError("name is required for 'create' action")
|
|
input_data: dict[str, Any] = {"name": name}
|
|
if roles is not None:
|
|
input_data["roles"] = roles
|
|
if permissions is not None:
|
|
input_data["permissions"] = permissions
|
|
data = await make_graphql_request(MUTATIONS["create"], {"input": input_data})
|
|
return {
|
|
"success": True,
|
|
"key": data.get("createApiKey", {}),
|
|
}
|
|
|
|
if action == "update":
|
|
if not key_id:
|
|
raise ToolError("key_id is required for 'update' action")
|
|
input_data: dict[str, Any] = {"id": key_id}
|
|
if name:
|
|
input_data["name"] = name
|
|
if roles is not None:
|
|
input_data["roles"] = roles
|
|
data = await make_graphql_request(MUTATIONS["update"], {"input": input_data})
|
|
return {
|
|
"success": True,
|
|
"key": data.get("updateApiKey", {}),
|
|
}
|
|
|
|
if action == "delete":
|
|
if not key_id:
|
|
raise ToolError("key_id is required for 'delete' action")
|
|
data = await make_graphql_request(MUTATIONS["delete"], {"input": {"ids": [key_id]}})
|
|
result = data.get("deleteApiKeys")
|
|
if not result:
|
|
raise ToolError(
|
|
f"Failed to delete API key '{key_id}': no confirmation from server"
|
|
)
|
|
return {
|
|
"success": True,
|
|
"message": f"API key '{key_id}' deleted",
|
|
}
|
|
|
|
raise ToolError(f"Unhandled action '{action}' — this is a bug")
|
|
|
|
logger.info("Keys tool registered successfully")
|