Files
unraid-mcp/skills/unraid/scripts/unraid-query.sh
Jacob Magar 37e9424a5c fix: address 54 MEDIUM/LOW priority PR review issues
Comprehensive fixes across Python code, shell scripts, and documentation
addressing all remaining MEDIUM and LOW priority review comments.

Python Code Fixes (27 fixes):
- tools/info.py: Simplified dispatch with lookup tables, defensive guards,
  CPU fallback formatting, !s conversion flags, module-level sync assertion
- tools/docker.py: Case-insensitive container ID regex, keyword-only confirm,
  module-level ALL_ACTIONS constant
- tools/virtualization.py: Normalized single-VM dict responses, unified
  list/details queries
- core/client.py: Fixed HTTP client singleton race condition, compound key
  substring matching for sensitive data redaction
- subscriptions/: Extracted SSL context creation to shared helper in utils.py,
  replaced deprecated ssl._create_unverified_context API
- tools/array.py: Renamed parity_history to parity_status, hoisted ALL_ACTIONS
- tools/storage.py: Fixed dict(None) risks, temperature 0 falsiness bug
- tools/notifications.py, keys.py, rclone.py: Fixed dict(None) TypeError risks
- tests/: Fixed generator type annotations, added coverage for compound keys

Shell Script Fixes (13 fixes):
- dashboard.sh: Dynamic server discovery, conditional debug output, null-safe
  jq, notification count guard order, removed unused variables
- unraid-query.sh: Proper JSON escaping via jq, --ignore-errors and --insecure
  CLI flags, TLS verification now on by default
- validate-marketplace.sh: Removed unused YELLOW variable, defensive jq,
  simplified repository URL output

Documentation Fixes (24+ fixes):
- Version consistency: Updated all references to v0.2.0 across pyproject.toml,
  plugin.json, marketplace.json, MARKETPLACE.md, __init__.py, README files
- Tool count updates: Changed all "26 tools" references to "10 tools, 90 actions"
- Markdown lint: Fixed MD022, MD031, MD047 issues across multiple files
- Research docs: Fixed auth headers, removed web artifacts, corrected stale info
- Skills docs: Fixed query examples, endpoint counts, env var references

All 227 tests pass, ruff and ty checks clean.
2026-02-15 17:09:31 -05:00

146 lines
3.3 KiB
Bash
Executable File

#!/bin/bash
# Unraid GraphQL API Query Helper
# Makes it easy to query the Unraid API from the command line
set -e
# Usage function
usage() {
cat << EOF
Usage: $0 [OPTIONS]
Query the Unraid GraphQL API
OPTIONS:
-u, --url URL Unraid server URL (required)
-k, --key KEY API key (required)
-q, --query QUERY GraphQL query (required)
-f, --format FORMAT Output format: json (default), raw, pretty
--ignore-errors Continue if GraphQL returns data alongside errors
--insecure Disable TLS certificate verification
-h, --help Show this help message
ENVIRONMENT VARIABLES:
UNRAID_URL Default Unraid server URL
UNRAID_API_KEY Default API key
EXAMPLES:
# Get system status
$0 -u https://unraid.local/graphql -k YOUR_KEY -q "{ online }"
# Use environment variables
export UNRAID_URL="https://unraid.local/graphql"
export UNRAID_API_KEY="your-api-key"
$0 -q "{ metrics { cpu { percentTotal } } }"
# Pretty print output
$0 -q "{ array { state } }" -f pretty
EOF
exit 1
}
# Default values
URL="${UNRAID_URL:-}"
API_KEY="${UNRAID_API_KEY:-}"
QUERY=""
FORMAT="json"
IGNORE_ERRORS="${IGNORE_ERRORS:-false}"
INSECURE="false"
# Parse arguments
while [[ $# -gt 0 ]]; do
case $1 in
-u|--url)
URL="$2"
shift 2
;;
-k|--key)
API_KEY="$2"
shift 2
;;
-q|--query)
QUERY="$2"
shift 2
;;
-f|--format)
FORMAT="$2"
shift 2
;;
--ignore-errors)
IGNORE_ERRORS="true"
shift
;;
--insecure)
INSECURE="true"
shift
;;
-h|--help)
usage
;;
*)
echo "Unknown option: $1"
usage
;;
esac
done
# Validate required arguments
if [[ -z "$URL" ]]; then
echo "Error: Unraid URL is required (use -u or set UNRAID_URL)"
exit 1
fi
if [[ -z "$API_KEY" ]]; then
echo "Error: API key is required (use -k or set UNRAID_API_KEY)"
exit 1
fi
if [[ -z "$QUERY" ]]; then
echo "Error: GraphQL query is required (use -q)"
exit 1
fi
# Build JSON payload with proper escaping
PAYLOAD=$(jq -n --arg q "$QUERY" '{"query": $q}')
# Build curl flags
CURL_FLAGS=("-sL" "-X" "POST")
[[ "$INSECURE" == "true" ]] && CURL_FLAGS+=("-k")
# Make the request
RESPONSE=$(curl "${CURL_FLAGS[@]}" "$URL" \
-H "Content-Type: application/json" \
-H "x-api-key: $API_KEY" \
-d "$PAYLOAD")
# Check for errors
if echo "$RESPONSE" | jq -e '.errors' > /dev/null 2>&1; then
# If we have data despite errors and --ignore-errors was passed, continue
if [[ "$IGNORE_ERRORS" == "true" ]] && echo "$RESPONSE" | jq -e '.data' > /dev/null 2>&1; then
echo "GraphQL Warning:" >&2
echo "$RESPONSE" | jq -r '.errors[0].message' >&2
else
echo "GraphQL Error:" >&2
echo "$RESPONSE" | jq -r '.errors[0].message' >&2
exit 1
fi
fi
# Output based on format
case "$FORMAT" in
json)
echo "$RESPONSE"
;;
raw)
echo "$RESPONSE" | jq -r '.data'
;;
pretty)
echo "$RESPONSE" | jq '.'
;;
*)
echo "Unknown format: $FORMAT" >&2
exit 1
;;
esac