forked from HomeLab/unraid-mcp
348f4149a5
Resolves review threads:
- PRRT_kwDOO6Hdxs5vNroH (Thread 36): tests now verify generic ToolError message
instead of raw exception text (security: no sensitive data in user-facing errors)
- PRRT_kwDOO6Hdxs5vNuYg (Thread 14): format_kb KB branch now uses :.2f like all
other branches (consistency fix)
- I001/F841/PERF401: fix ruff violations in http_layer, integration, safety tests
Changes:
- tests/test_array.py: match "Failed to execute array/parity_status" (not raw error)
- tests/test_keys.py: match "Failed to execute keys/list" (not raw error)
- tests/test_notifications.py: match "Failed to execute notifications/overview" (not raw error)
- tests/test_storage.py: update format_kb assertion to "512.00 KB" (:.2f format)
- tests/http_layer/test_request_construction.py: remove unused result var (F841)
+ fix import sort (I001)
- tests/safety/test_destructive_guards.py: use list.extend (PERF401) + fix import sort
- unraid_mcp/core/utils.py: format_kb returns f"{k:.2f} KB" for sub-MB values
Co-authored-by: @coderabbitai
Co-authored-by: @cubic-dev-ai
Co-authored-by: @copilot-pull-request-reviewer
105 lines
3.9 KiB
Python
105 lines
3.9 KiB
Python
"""Tests for unraid_keys tool."""
|
|
|
|
from collections.abc import Generator
|
|
from unittest.mock import AsyncMock, patch
|
|
|
|
import pytest
|
|
from conftest import make_tool_fn
|
|
|
|
from unraid_mcp.core.exceptions import ToolError
|
|
|
|
|
|
@pytest.fixture
|
|
def _mock_graphql() -> Generator[AsyncMock, None, None]:
|
|
with patch("unraid_mcp.tools.keys.make_graphql_request", new_callable=AsyncMock) as mock:
|
|
yield mock
|
|
|
|
|
|
def _make_tool():
|
|
return make_tool_fn("unraid_mcp.tools.keys", "register_keys_tool", "unraid_keys")
|
|
|
|
|
|
class TestKeysValidation:
|
|
async def test_delete_requires_confirm(self, _mock_graphql: AsyncMock) -> None:
|
|
tool_fn = _make_tool()
|
|
with pytest.raises(ToolError, match="destructive"):
|
|
await tool_fn(action="delete", key_id="k:1")
|
|
|
|
async def test_get_requires_key_id(self, _mock_graphql: AsyncMock) -> None:
|
|
tool_fn = _make_tool()
|
|
with pytest.raises(ToolError, match="key_id"):
|
|
await tool_fn(action="get")
|
|
|
|
async def test_create_requires_name(self, _mock_graphql: AsyncMock) -> None:
|
|
tool_fn = _make_tool()
|
|
with pytest.raises(ToolError, match="name"):
|
|
await tool_fn(action="create")
|
|
|
|
async def test_update_requires_key_id(self, _mock_graphql: AsyncMock) -> None:
|
|
tool_fn = _make_tool()
|
|
with pytest.raises(ToolError, match="key_id"):
|
|
await tool_fn(action="update")
|
|
|
|
async def test_delete_requires_key_id(self, _mock_graphql: AsyncMock) -> None:
|
|
tool_fn = _make_tool()
|
|
with pytest.raises(ToolError, match="key_id"):
|
|
await tool_fn(action="delete", confirm=True)
|
|
|
|
|
|
class TestKeysActions:
|
|
async def test_list(self, _mock_graphql: AsyncMock) -> None:
|
|
_mock_graphql.return_value = {
|
|
"apiKeys": [{"id": "k:1", "name": "mcp-key", "roles": ["admin"]}]
|
|
}
|
|
tool_fn = _make_tool()
|
|
result = await tool_fn(action="list")
|
|
assert len(result["keys"]) == 1
|
|
|
|
async def test_get(self, _mock_graphql: AsyncMock) -> None:
|
|
_mock_graphql.return_value = {
|
|
"apiKey": {"id": "k:1", "name": "mcp-key", "roles": ["admin"]}
|
|
}
|
|
tool_fn = _make_tool()
|
|
result = await tool_fn(action="get", key_id="k:1")
|
|
assert result["name"] == "mcp-key"
|
|
|
|
async def test_create(self, _mock_graphql: AsyncMock) -> None:
|
|
_mock_graphql.return_value = {
|
|
"createApiKey": {"id": "k:new", "name": "new-key", "key": "secret123", "roles": []}
|
|
}
|
|
tool_fn = _make_tool()
|
|
result = await tool_fn(action="create", name="new-key")
|
|
assert result["success"] is True
|
|
assert result["key"]["name"] == "new-key"
|
|
|
|
async def test_create_with_roles(self, _mock_graphql: AsyncMock) -> None:
|
|
_mock_graphql.return_value = {
|
|
"createApiKey": {
|
|
"id": "k:new",
|
|
"name": "admin-key",
|
|
"key": "secret",
|
|
"roles": ["admin"],
|
|
}
|
|
}
|
|
tool_fn = _make_tool()
|
|
result = await tool_fn(action="create", name="admin-key", roles=["admin"])
|
|
assert result["success"] is True
|
|
|
|
async def test_update(self, _mock_graphql: AsyncMock) -> None:
|
|
_mock_graphql.return_value = {"updateApiKey": {"id": "k:1", "name": "renamed", "roles": []}}
|
|
tool_fn = _make_tool()
|
|
result = await tool_fn(action="update", key_id="k:1", name="renamed")
|
|
assert result["success"] is True
|
|
|
|
async def test_delete(self, _mock_graphql: AsyncMock) -> None:
|
|
_mock_graphql.return_value = {"deleteApiKeys": True}
|
|
tool_fn = _make_tool()
|
|
result = await tool_fn(action="delete", key_id="k:1", confirm=True)
|
|
assert result["success"] is True
|
|
|
|
async def test_generic_exception_wraps(self, _mock_graphql: AsyncMock) -> None:
|
|
_mock_graphql.side_effect = RuntimeError("connection lost")
|
|
tool_fn = _make_tool()
|
|
with pytest.raises(ToolError, match="Failed to execute keys/list"):
|
|
await tool_fn(action="list")
|