From 8023b61a415d03f6e28e2427ae077857b15a474f Mon Sep 17 00:00:00 2001
From: Jiiniasu <jiiniasu@unsuspicious.email>
Date: Sun, 18 Aug 2024 14:53:25 +0200
Subject: [PATCH] Fix delayed perfect line effect (#704)

* Fix delayed perfect line effect

* Address Sonarcloud issues for CNoteBars.cs

* Fix out of range bug caused by removing last()
---
 VocaluxeLib/Menu/SingNotes/CNoteBars.cs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/VocaluxeLib/Menu/SingNotes/CNoteBars.cs b/VocaluxeLib/Menu/SingNotes/CNoteBars.cs
index 585fb62f..968871ad 100644
--- a/VocaluxeLib/Menu/SingNotes/CNoteBars.cs
+++ b/VocaluxeLib/Menu/SingNotes/CNoteBars.cs
@@ -145,10 +145,10 @@ namespace VocaluxeLib.Menu.SingNotes
                 }
             }
 
-            if (_CurrentLine > 0 && sungLines.Count >= _CurrentLine && sungLines[_CurrentLine - 1].PerfectLine)
+            if (sungLines.Count > 0 && sungLines[sungLines.Count - 1].PerfectLine)
             {
                 _AddPerfectLine();
-                sungLines[_CurrentLine - 1].PerfectLine = false;
+                sungLines[sungLines.Count - 1].PerfectLine = false;
             }
 
             _Flares.RemoveAll(el => !el.IsAlive);
@@ -237,7 +237,7 @@ namespace VocaluxeLib.Menu.SingNotes
             CBase.Drawing.DrawTexture(toneHelper, drawRect, color, false);
         }
 
-        private void _DrawNote(SRectF rect, SColorF color, CTextureRef noteBegin, CTextureRef noteMiddle, CTextureRef noteEnd, float factor)
+        private static void _DrawNote(SRectF rect, SColorF color, CTextureRef noteBegin, CTextureRef noteMiddle, CTextureRef noteEnd, float factor)
         {
             if (factor <= 0)
                 return;