Apply R# clean-up for reliability (#877)
* Apply R# clean-up for reliability - Migrate to NUnit4 Assert.That - Update dependencise versions - Fix LangVersion to 9.0 (until net core migration) - Reformat code - Apply 'var' style (easier for refactoring) - Remove redundant parentheses - Add braces on every condition blocks (1 line) - Uses new null checking patterns - Uses AutoProperties when possible - Uses string scalar type instead of class - Clean usings - Add .orig files in git ignore - Rename some properties to respect defined conventions and US format definition - ID -> Id - BPM -> Bpm - Finish -> End * Update R# settings according to the clean-up made
This commit is contained in:
1 parent
b9b0f7c8df
commit
6ffa63b923
236 files changed
+14194
-7278
No files matched your search
@@ -66,16 +66,17 @@ namespace VocaluxeLib.Songs
|
||||
#region Methods
|
||||
public void CheckPerfect()
|
||||
{
|
||||
bool result = HitNote != null;
|
||||
var result = HitNote != null;
|
||||
if (result)
|
||||
{
|
||||
result = (StartBeat == HitNote.StartBeat);
|
||||
result &= (EndBeat == HitNote.EndBeat);
|
||||
result &= (Tone == HitNote.Tone);
|
||||
result = StartBeat == HitNote.StartBeat;
|
||||
result &= EndBeat == HitNote.EndBeat;
|
||||
result &= Tone == HitNote.Tone;
|
||||
}
|
||||
|
||||
Perfect = result;
|
||||
}
|
||||
|
||||
public override bool IsNoteType(params ENoteType[] noteTypes)
|
||||
{
|
||||
return HitNote != null && noteTypes.Contains(HitNote.Type);
|
||||
@@ -84,7 +85,7 @@ namespace VocaluxeLib.Songs
|
||||
|
||||
public override int PointsForBeat
|
||||
{
|
||||
get { return (HitNote == null) ? 0 : HitNote.PointsForBeat; }
|
||||
get { return HitNote == null ? 0 : HitNote.PointsForBeat; }
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user