Apply R# clean-up for reliability (#877)
* Apply R# clean-up for reliability - Migrate to NUnit4 Assert.That - Update dependencise versions - Fix LangVersion to 9.0 (until net core migration) - Reformat code - Apply 'var' style (easier for refactoring) - Remove redundant parentheses - Add braces on every condition blocks (1 line) - Uses new null checking patterns - Uses AutoProperties when possible - Uses string scalar type instead of class - Clean usings - Add .orig files in git ignore - Rename some properties to respect defined conventions and US format definition - ID -> Id - BPM -> Bpm - Finish -> End * Update R# settings according to the clean-up made
This commit is contained in:
1 parent
b9b0f7c8df
commit
6ffa63b923
236 files changed
+14194
-7278
No files matched your search
@@ -41,7 +41,9 @@ namespace VocaluxeLib.Songs
|
||||
Duration = duration;
|
||||
Tone = tone;
|
||||
if (Duration < 1)
|
||||
{
|
||||
throw new Exception("Note to short. All notes should be at least 1 beat long!");
|
||||
}
|
||||
}
|
||||
#endregion Constructors
|
||||
|
||||
@@ -62,7 +64,9 @@ namespace VocaluxeLib.Songs
|
||||
set
|
||||
{
|
||||
if (value > 0)
|
||||
{
|
||||
_Duration = value;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -72,13 +76,18 @@ namespace VocaluxeLib.Songs
|
||||
{
|
||||
// Always return 0 for Rap notes
|
||||
if (IsRapNote)
|
||||
{
|
||||
return 0;
|
||||
}
|
||||
|
||||
return _Tone;
|
||||
}
|
||||
set
|
||||
{
|
||||
if ((value >= CBase.Settings.GetToneMin()) && (value <= CBase.Settings.GetToneMax()))
|
||||
if (value >= CBase.Settings.GetToneMin() && value <= CBase.Settings.GetToneMax())
|
||||
{
|
||||
_Tone = value;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -104,4 +113,4 @@ namespace VocaluxeLib.Songs
|
||||
public abstract bool IsNoteType(params ENoteType[] noteTypes);
|
||||
#endregion Methods
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user