Apply R# clean-up for reliability (#877)

* Apply R# clean-up for reliability

- Migrate to NUnit4 Assert.That
- Update dependencise versions
- Fix LangVersion to 9.0 (until net core migration)
- Reformat code
- Apply 'var' style (easier for refactoring)
- Remove redundant parentheses
- Add braces on every condition blocks (1 line)
- Uses new null checking patterns
- Uses AutoProperties when possible
- Uses string scalar type instead of class
- Clean usings
- Add .orig files in git ignore
- Rename some properties to respect defined conventions and US format definition
	- ID -> Id
	- BPM -> Bpm
	- Finish -> End

* Update R# settings according to the clean-up made
This commit is contained in:
Quentin Bray authored and GitHub committed 2026-06-22 19:52:06 +02:00
1 parent b9b0f7c8df
commit 6ffa63b923
236 files changed
+14194 -7278

No files matched your search

+8 -7
View File
@@ -15,7 +15,6 @@
// along with Vocaluxe. If not, see <http://www.gnu.org/licenses/>.
#endregion
using System;
using VocaluxeLib.Menu;
namespace VocaluxeLib.PartyModes
@@ -65,10 +64,10 @@ namespace VocaluxeLib.PartyModes
_ScreenSongOptions.Selection.SongIndex = -1;
_ScreenSongOptions.Selection.CategoryIndex = -1;
_ScreenSongOptions.Sorting.SearchString = String.Empty;
_ScreenSongOptions.Sorting.SearchString = string.Empty;
_ScreenSongOptions.Sorting.SearchActive = false;
_ScreenSongOptions.Sorting.DuetOptions = EDuetOptions.All;
_ScreenSongOptions.Sorting.FilterPlaylistID = -1;
_ScreenSongOptions.Sorting.FilterPlaylistId = -1;
}
public override bool Init()
@@ -76,7 +75,7 @@ namespace VocaluxeLib.PartyModes
return true;
}
public override void UpdateGame() {}
public override void UpdateGame() { }
public override IMenu GetStartScreen()
{
@@ -89,16 +88,18 @@ namespace VocaluxeLib.PartyModes
_ScreenSongOptions.Sorting.Tabs = CBase.Config.GetTabs();
if (_ScreenSongOptions.Sorting.SearchActive)
{
_ScreenSongOptions.Sorting.Tabs = EOffOn.TR_CONFIG_OFF;
}
_ScreenSongOptions.Sorting.IgnoreArticles = CBase.Config.GetIgnoreArticles();
return _ScreenSongOptions;
}
public override void OnSongChange(int songIndex, ref SScreenSongOptions screenSongOptions) {}
public override void OnSongChange(int songIndex, ref SScreenSongOptions screenSongOptions) { }
public override void OnCategoryChange(int categoryIndex, ref SScreenSongOptions screenSongOptions) {}
public override void OnCategoryChange(int categoryIndex, ref SScreenSongOptions screenSongOptions) { }
public override void SetSearchString(string searchString, bool visible)
{
@@ -106,7 +107,7 @@ namespace VocaluxeLib.PartyModes
_ScreenSongOptions.Sorting.SearchActive = visible;
}
public override void SongSelected(int songID)
public override void SongSelected(int songId)
{
CBase.Graphics.FadeTo(EScreen.Sing);
}