Apply R# clean-up for reliability (#877)
* Apply R# clean-up for reliability - Migrate to NUnit4 Assert.That - Update dependencise versions - Fix LangVersion to 9.0 (until net core migration) - Reformat code - Apply 'var' style (easier for refactoring) - Remove redundant parentheses - Add braces on every condition blocks (1 line) - Uses new null checking patterns - Uses AutoProperties when possible - Uses string scalar type instead of class - Clean usings - Add .orig files in git ignore - Rename some properties to respect defined conventions and US format definition - ID -> Id - BPM -> Bpm - Finish -> End * Update R# settings according to the clean-up made
This commit is contained in:
1 parent
b9b0f7c8df
commit
6ffa63b923
236 files changed
+14194
-7278
No files matched your search
@@ -21,34 +21,27 @@ namespace VocaluxeLib.Menu.SongMenu
|
||||
{
|
||||
public static class CSongMenuFactory
|
||||
{
|
||||
public static ISongMenu CreateSongMenu(SThemeSongMenu theme, int partyModeID)
|
||||
public static ISongMenu CreateSongMenu(SThemeSongMenu theme, int partyModeId)
|
||||
{
|
||||
switch (CBase.Config.GetSongMenuType())
|
||||
{
|
||||
case ESongMenu.TR_CONFIG_LIST:
|
||||
return new CSongMenuList(theme, partyModeID);
|
||||
|
||||
//case ESongMenu.TR_CONFIG_DREIDEL:
|
||||
// _SongMenu = new CSongMenuDreidel();
|
||||
// break;
|
||||
return new CSongMenuList(theme, partyModeId);
|
||||
case ESongMenu.TR_CONFIG_TILE_BOARD:
|
||||
return new CSongMenuTileBoard(theme, partyModeID);
|
||||
|
||||
//case ESongMenu.TR_CONFIG_BOOK:
|
||||
// _SongMenu = new CSongMenuBook();
|
||||
// break;
|
||||
return new CSongMenuTileBoard(theme, partyModeId);
|
||||
}
|
||||
|
||||
throw new ArgumentException("Invalid songmenu type: " + CBase.Config.GetSongMenuType());
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Deprecated! Only used for old theme loading.
|
||||
/// </summary>
|
||||
/// <param name="partyModeID"></param>
|
||||
/// <param name="partyModeId"></param>
|
||||
/// <returns></returns>
|
||||
public static ISongMenu CreateSongMenu(int partyModeID)
|
||||
public static ISongMenu CreateSongMenu(int partyModeId)
|
||||
{
|
||||
return new CSongMenuTileBoard(partyModeID);
|
||||
return new CSongMenuTileBoard(partyModeId);
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user