Partymodes: Fix "Select random" button selecting invalid profiles

which would happen if the number of visible profiles matched the number of used profiles or if there were more slots than usable profiles

VocaluxeLib/Menu/CMenuPartyNameSelection.cs

@@ -774,7 +774,8 @@ namespace VocaluxeLib.Menu
                 for (int p = 0; p < _NumPlayerTeams[t]; p++)
                 {
                     int profileID = _NameSelections[_NameSelection].GetRandomUnusedProfile();
-                    _AddPlayer(t, profileID);
+                    if(profileID >= 0) //only add valid profiles
+                        _AddPlayer(t, profileID);
                 }
             }
         }

VocaluxeLib/Menu/CNameSelection.cs

@@ -465,23 +465,11 @@ namespace VocaluxeLib.Menu
 
         public int GetRandomUnusedProfile()
         {
-            int id = -1;
-
             if (_VisibleProfiles.Count == 0)
-                return id;
+                return -1;
 
-            if (_VisibleProfiles.Count == _UsedProfiles.Count)
+            int rand = CBase.Game.GetRandom(_VisibleProfiles.Count);
-                return id;
+            return _VisibleProfiles[rand];
-
-            while (id == -1)
-            {
-                int rand = CBase.Game.GetRandom(_VisibleProfiles.Count);
-                if (_UsedProfiles.Contains(_VisibleProfiles[rand]))
-                    continue;
-                id = _VisibleProfiles[rand];
-            }
-
-            return id;
         }
 
         private void _PrepareTiles()