mirror of
https://github.com/jmagar/unraid-mcp.git
synced 2026-03-01 16:04:24 -08:00
37e9424a5c
Comprehensive fixes across Python code, shell scripts, and documentation addressing all remaining MEDIUM and LOW priority review comments. Python Code Fixes (27 fixes): - tools/info.py: Simplified dispatch with lookup tables, defensive guards, CPU fallback formatting, !s conversion flags, module-level sync assertion - tools/docker.py: Case-insensitive container ID regex, keyword-only confirm, module-level ALL_ACTIONS constant - tools/virtualization.py: Normalized single-VM dict responses, unified list/details queries - core/client.py: Fixed HTTP client singleton race condition, compound key substring matching for sensitive data redaction - subscriptions/: Extracted SSL context creation to shared helper in utils.py, replaced deprecated ssl._create_unverified_context API - tools/array.py: Renamed parity_history to parity_status, hoisted ALL_ACTIONS - tools/storage.py: Fixed dict(None) risks, temperature 0 falsiness bug - tools/notifications.py, keys.py, rclone.py: Fixed dict(None) TypeError risks - tests/: Fixed generator type annotations, added coverage for compound keys Shell Script Fixes (13 fixes): - dashboard.sh: Dynamic server discovery, conditional debug output, null-safe jq, notification count guard order, removed unused variables - unraid-query.sh: Proper JSON escaping via jq, --ignore-errors and --insecure CLI flags, TLS verification now on by default - validate-marketplace.sh: Removed unused YELLOW variable, defensive jq, simplified repository URL output Documentation Fixes (24+ fixes): - Version consistency: Updated all references to v0.2.0 across pyproject.toml, plugin.json, marketplace.json, MARKETPLACE.md, __init__.py, README files - Tool count updates: Changed all "26 tools" references to "10 tools, 90 actions" - Markdown lint: Fixed MD022, MD031, MD047 issues across multiple files - Research docs: Fixed auth headers, removed web artifacts, corrected stale info - Skills docs: Fixed query examples, endpoint counts, env var references All 227 tests pass, ruff and ty checks clean.
105 lines
4.0 KiB
Python
105 lines
4.0 KiB
Python
"""Tests for unraid_rclone tool."""
|
|
|
|
from collections.abc import Generator
|
|
from unittest.mock import AsyncMock, patch
|
|
|
|
import pytest
|
|
from conftest import make_tool_fn
|
|
|
|
from unraid_mcp.core.exceptions import ToolError
|
|
|
|
|
|
@pytest.fixture
|
|
def _mock_graphql() -> Generator[AsyncMock, None, None]:
|
|
with patch("unraid_mcp.tools.rclone.make_graphql_request", new_callable=AsyncMock) as mock:
|
|
yield mock
|
|
|
|
|
|
def _make_tool():
|
|
return make_tool_fn("unraid_mcp.tools.rclone", "register_rclone_tool", "unraid_rclone")
|
|
|
|
|
|
@pytest.mark.usefixtures("_mock_graphql")
|
|
class TestRcloneValidation:
|
|
async def test_delete_requires_confirm(self) -> None:
|
|
tool_fn = _make_tool()
|
|
with pytest.raises(ToolError, match="destructive"):
|
|
await tool_fn(action="delete_remote", name="gdrive")
|
|
|
|
async def test_create_requires_fields(self) -> None:
|
|
tool_fn = _make_tool()
|
|
with pytest.raises(ToolError, match="requires name"):
|
|
await tool_fn(action="create_remote")
|
|
|
|
async def test_delete_requires_name(self) -> None:
|
|
tool_fn = _make_tool()
|
|
with pytest.raises(ToolError, match="name is required"):
|
|
await tool_fn(action="delete_remote", confirm=True)
|
|
|
|
|
|
class TestRcloneActions:
|
|
async def test_list_remotes(self, _mock_graphql: AsyncMock) -> None:
|
|
_mock_graphql.return_value = {
|
|
"rclone": {"remotes": [{"name": "gdrive", "type": "drive"}]}
|
|
}
|
|
tool_fn = _make_tool()
|
|
result = await tool_fn(action="list_remotes")
|
|
assert len(result["remotes"]) == 1
|
|
|
|
async def test_config_form(self, _mock_graphql: AsyncMock) -> None:
|
|
_mock_graphql.return_value = {
|
|
"rclone": {"configForm": {"id": "form:1", "dataSchema": {}, "uiSchema": {}}}
|
|
}
|
|
tool_fn = _make_tool()
|
|
result = await tool_fn(action="config_form")
|
|
assert result["id"] == "form:1"
|
|
|
|
async def test_config_form_with_provider(self, _mock_graphql: AsyncMock) -> None:
|
|
_mock_graphql.return_value = {
|
|
"rclone": {"configForm": {"id": "form:s3", "dataSchema": {}, "uiSchema": {}}}
|
|
}
|
|
tool_fn = _make_tool()
|
|
result = await tool_fn(action="config_form", provider_type="s3")
|
|
assert result["id"] == "form:s3"
|
|
call_args = _mock_graphql.call_args
|
|
assert call_args[0][1] == {"formOptions": {"providerType": "s3"}}
|
|
|
|
async def test_create_remote(self, _mock_graphql: AsyncMock) -> None:
|
|
_mock_graphql.return_value = {
|
|
"rclone": {"createRCloneRemote": {"name": "newremote", "type": "s3"}}
|
|
}
|
|
tool_fn = _make_tool()
|
|
result = await tool_fn(
|
|
action="create_remote",
|
|
name="newremote",
|
|
provider_type="s3",
|
|
config_data={"bucket": "mybucket"},
|
|
)
|
|
assert result["success"] is True
|
|
|
|
async def test_create_remote_with_empty_config(self, _mock_graphql: AsyncMock) -> None:
|
|
"""Empty config_data dict should be accepted (not rejected by truthiness)."""
|
|
_mock_graphql.return_value = {
|
|
"rclone": {"createRCloneRemote": {"name": "ftp-remote", "type": "ftp"}}
|
|
}
|
|
tool_fn = _make_tool()
|
|
result = await tool_fn(
|
|
action="create_remote",
|
|
name="ftp-remote",
|
|
provider_type="ftp",
|
|
config_data={},
|
|
)
|
|
assert result["success"] is True
|
|
|
|
async def test_delete_remote(self, _mock_graphql: AsyncMock) -> None:
|
|
_mock_graphql.return_value = {"rclone": {"deleteRCloneRemote": True}}
|
|
tool_fn = _make_tool()
|
|
result = await tool_fn(action="delete_remote", name="gdrive", confirm=True)
|
|
assert result["success"] is True
|
|
|
|
async def test_delete_remote_failure(self, _mock_graphql: AsyncMock) -> None:
|
|
_mock_graphql.return_value = {"rclone": {"deleteRCloneRemote": False}}
|
|
tool_fn = _make_tool()
|
|
with pytest.raises(ToolError, match="Failed to delete"):
|
|
await tool_fn(action="delete_remote", name="gdrive", confirm=True)
|