Files
unraid-mcp/CLAUDE.md
Jacob Magar d0cc99711a fix: address remaining PR review threads (docs, test-destructive, rclone test)
Resolves review threads:
- PRRT_kwDOO6Hdxs50T0Wp (test-destructive.sh: add key cleanup on failure path)
- PRRT_kwDOO6Hdxs50T0Ws (test-destructive.sh: pick last notification match by title)
- PRRT_kwDOO6Hdxs50T0Wt (README.md: correct test-actions.sh coverage description)
- PRRT_kwDOO6Hdxs50T0Wv (CLAUDE.md: add info.update_ssh to destructive actions list)
- PRRT_kwDOO6Hdxs50T0Wy (http_layer test: inp["config"] -> inp["parameters"])
- PRRT_kwDOO6Hdxs50T0Wz (DESTRUCTIVE_ACTIONS.md: key ID extraction key.id not top-level)
- PRRT_kwDOO6Hdxs50T0W2 (DESTRUCTIVE_ACTIONS.md: delete_archived — add archive step)
- PRRT_kwDOO6Hdxs50T0W3 (DESTRUCTIVE_ACTIONS.md: rclone params provider_type/config_data/name)
- PRRT_kwDOO6Hdxs50T0W4 (DESTRUCTIVE_ACTIONS.md: notification delete list+match pattern)
- PRRT_kwDOO6Hdxs50T0W5 (DESTRUCTIVE_ACTIONS.md: create_folder uses folder_name param)
- PRRT_kwDOO6Hdxs50T0W7 (README.md: cleanup note — test-tools.sh may write tmp log file)

Changes:
- test-destructive.sh keys test: attempt key delete cleanup when delete step fails
- test-destructive.sh notifications test: reverse list to pick most-recent title match
- tests/mcporter/README.md: accurate coverage claim; accurate cleanup section
- CLAUDE.md: info.update_ssh added to destructive actions list
- tests/http_layer/test_request_construction.py: assert parameters not config field
- docs/DESTRUCTIVE_ACTIONS.md: all 5 example code blocks corrected with right
  parameter names, correct ID extraction paths, and proper sequencing

Co-authored-by: Claude <noreply@anthropic.com>
2026-03-13 23:29:14 -04:00

8.3 KiB

CLAUDE.md

This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.

Project Overview

This is an MCP (Model Context Protocol) server that provides tools to interact with an Unraid server's GraphQL API. The server is built using FastMCP with a modular architecture consisting of separate packages for configuration, core functionality, subscriptions, and tools.

Development Commands

Setup

# Initialize uv virtual environment and install dependencies
uv sync

# Install dev dependencies
uv sync --group dev

Running the Server

# Local development with uv (recommended)
uv run unraid-mcp-server

# Direct module execution
uv run -m unraid_mcp.main

Code Quality

# Lint and format with ruff
uv run ruff check unraid_mcp/
uv run ruff format unraid_mcp/

# Type checking with ty (Astral's fast type checker)
uv run ty check unraid_mcp/

# Run tests
uv run pytest

Docker Development

# Build the Docker image
docker build -t unraid-mcp-server .

# Run with Docker Compose
docker compose up -d

# View logs
docker compose logs -f unraid-mcp

# Stop service
docker compose down

Environment Setup

  • Copy .env.example to .env and configure:
    • UNRAID_API_URL: Unraid GraphQL endpoint (required)
    • UNRAID_API_KEY: Unraid API key (required)
    • UNRAID_MCP_TRANSPORT: Transport type (default: streamable-http)
    • UNRAID_MCP_PORT: Server port (default: 6970)
    • UNRAID_MCP_HOST: Server host (default: 0.0.0.0)

Architecture

Core Components

  • Main Server: unraid_mcp/server.py - Modular MCP server with FastMCP integration
  • Entry Point: unraid_mcp/main.py - Application entry point and startup logic
  • Configuration: unraid_mcp/config/ - Settings management and logging configuration
  • Core Infrastructure: unraid_mcp/core/ - GraphQL client, exceptions, and shared types
  • Subscriptions: unraid_mcp/subscriptions/ - Real-time WebSocket subscriptions and diagnostics
  • Tools: unraid_mcp/tools/ - Domain-specific tool implementations
  • GraphQL Client: Uses httpx for async HTTP requests to Unraid API
  • Transport Layer: Supports streamable-http (recommended), SSE (deprecated), and stdio

Key Design Patterns

  • Consolidated Action Pattern: Each tool uses action: Literal[...] parameter to expose multiple operations via a single MCP tool, reducing context window usage
  • Pre-built Query Dicts: QUERIES and MUTATIONS dicts prevent GraphQL injection and organize operations
  • Destructive Action Safety: DESTRUCTIVE_ACTIONS sets require confirm=True for dangerous operations
  • Modular Architecture: Clean separation of concerns across focused modules
  • Error Handling: Uses ToolError for user-facing errors, detailed logging for debugging
  • Timeout Management: Custom timeout configurations for different query types (90s for disk ops)
  • Data Processing: Tools return both human-readable summaries and detailed raw data
  • Health Monitoring: Comprehensive health check tool for system monitoring
  • Real-time Subscriptions: WebSocket-based live data streaming

Tool Categories (11 Tools, ~104 Actions)

  1. unraid_info (21 actions): overview, array, network, registration, connect, variables, metrics, services, display, config, online, owner, settings, server, servers, flash, ups_devices, ups_device, ups_config, update_server, update_ssh
  2. unraid_array (5 actions): parity_start, parity_pause, parity_resume, parity_cancel, parity_status
  3. unraid_storage (7 actions): shares, disks, disk_details, unassigned, log_files, logs, flash_backup
  4. unraid_docker (26 actions): list, details, start, stop, restart, pause, unpause, remove, update, update_all, logs, networks, network_details, port_conflicts, check_updates, create_folder, set_folder_children, delete_entries, move_to_folder, move_to_position, rename_folder, create_folder_with_items, update_view_prefs, sync_templates, reset_template_mappings, refresh_digests
  5. unraid_vm (9 actions): list, details, start, stop, pause, resume, force_stop, reboot, reset
  6. unraid_notifications (9 actions): overview, list, warnings, create, archive, unread, delete, delete_archived, archive_all
  7. unraid_rclone (4 actions): list_remotes, config_form, create_remote, delete_remote
  8. unraid_users (1 action): me
  9. unraid_keys (5 actions): list, get, create, update, delete
  10. unraid_health (3 actions): check, test_connection, diagnose
  11. unraid_settings (9 actions): update, update_temperature, update_time, configure_ups, update_api, connect_sign_in, connect_sign_out, setup_remote_access, enable_dynamic_remote_access

Destructive Actions (require confirm=True)

  • docker: remove, update_all, delete_entries, reset_template_mappings
  • vm: force_stop, reset
  • notifications: delete, delete_archived
  • rclone: delete_remote
  • keys: delete
  • storage: flash_backup
  • info: update_ssh
  • settings: configure_ups, setup_remote_access, enable_dynamic_remote_access

Environment Variable Hierarchy

The server loads environment variables from multiple locations in order:

  1. /app/.env.local (container mount)
  2. ../.env.local (project root)
  3. ../.env (project root)
  4. .env (local directory)

Transport Configuration

  • streamable-http (recommended): HTTP-based transport on /mcp endpoint
  • sse (deprecated): Server-Sent Events transport
  • stdio: Standard input/output for direct integration

Error Handling Strategy

  • GraphQL errors are converted to ToolError with descriptive messages
  • HTTP errors include status codes and response details
  • Network errors are caught and wrapped with connection context
  • All errors are logged with full context for debugging

Performance Considerations

  • Increased timeouts for disk operations (90s read timeout)
  • Selective queries to avoid GraphQL type overflow issues
  • Optional caching controls for Docker container queries
  • Log file overwrite at 10MB cap to prevent disk space issues

Critical Gotchas

Mutation Handler Ordering

Mutation handlers MUST return before the QUERIES[action] lookup. Mutations are not in the QUERIES dict — reaching that line for a mutation action causes a KeyError. Always add early-return if action == "mutation_name": ... return blocks BEFORE the QUERIES lookup.

Test Patching

  • Patch at the tool module level: unraid_mcp.tools.info.make_graphql_request (not core)
  • conftest.py's mock_graphql_request patches the core module — wrong for tool-level tests
  • Use conftest.py's make_tool_fn() helper or local _make_tool() pattern

Test Suite Structure

tests/
├── conftest.py           # Shared fixtures + make_tool_fn() helper
├── test_*.py             # Unit tests (mock at tool module level)
├── http_layer/           # httpx-level request/response tests (respx)
├── integration/          # WebSocket subscription lifecycle tests (slow)
├── safety/               # Destructive action guard tests
└── schema/               # GraphQL query validation (99 tests, all passing)

Running Targeted Tests

uv run pytest tests/safety/          # Destructive action guards only
uv run pytest tests/schema/          # GraphQL query validation only
uv run pytest tests/http_layer/      # HTTP/httpx layer only
uv run pytest tests/test_docker.py   # Single tool only
uv run pytest -x                     # Fail fast on first error

Scripts

# HTTP smoke-test against a live server (11 tools, all non-destructive actions)
./tests/mcporter/test-actions.sh [MCP_URL]  # default: http://localhost:6970/mcp

# stdio smoke-test, no running server needed (good for CI)
./tests/mcporter/test-tools.sh [--parallel] [--timeout-ms N] [--verbose]

See tests/mcporter/README.md for transport differences and docs/DESTRUCTIVE_ACTIONS.md for exact destructive-action test commands.

API Reference Docs

  • docs/UNRAID_API_COMPLETE_REFERENCE.md — Full GraphQL schema reference
  • docs/UNRAID_API_OPERATIONS.md — All supported operations with examples

Use these when adding new queries/mutations.

AGENTS.md and GEMINI.md are symlinks to CLAUDE.md for Codex/Gemini compatibility:

ln -sf CLAUDE.md AGENTS.md && ln -sf CLAUDE.md GEMINI.md