mirror of
https://github.com/jmagar/unraid-mcp.git
synced 2026-03-23 12:39:24 -07:00
dab1cd6995
BREAKING CHANGE: Replaces 15 separate MCP tools (unraid_info, unraid_array, unraid_storage, unraid_docker, unraid_vm, unraid_notifications, unraid_rclone, unraid_users, unraid_keys, unraid_health, unraid_settings, unraid_customization, unraid_plugins, unraid_oidc, unraid_live) with a single `unraid` tool using action (domain) + subaction (operation) routing. New interface: unraid(action="system", subaction="overview") replaces unraid_info(action="overview"). All 15 domains and ~108 subactions preserved. - Add unraid_mcp/tools/unraid.py (1891 lines, all domains consolidated) - Remove 15 individual tool files - Update tools/__init__.py to register single unified tool - Update server.py for new tool registration pattern - Update subscriptions/manager.py and resources.py for new tool names - Update all 25 test files + integration/contract/safety/schema/property tests - Update mcporter smoke-test script for new tool interface - Bump version 0.6.0 → 1.0.0 Co-authored-by: Claude <noreply@anthropic.com>
69 lines
2.4 KiB
Python
69 lines
2.4 KiB
Python
"""Tests for user subactions of the consolidated unraid tool.
|
|
|
|
NOTE: Unraid GraphQL API only supports the me() query.
|
|
User management operations (list, add, delete, cloud, remote_access, origins) are NOT available in the API.
|
|
"""
|
|
|
|
from collections.abc import Generator
|
|
from unittest.mock import AsyncMock, patch
|
|
|
|
import pytest
|
|
from conftest import make_tool_fn
|
|
|
|
from unraid_mcp.core.exceptions import ToolError
|
|
|
|
|
|
@pytest.fixture
|
|
def _mock_graphql() -> Generator[AsyncMock, None, None]:
|
|
with patch("unraid_mcp.tools.unraid.make_graphql_request", new_callable=AsyncMock) as mock:
|
|
yield mock
|
|
|
|
|
|
def _make_tool():
|
|
return make_tool_fn("unraid_mcp.tools.unraid", "register_unraid_tool", "unraid")
|
|
|
|
|
|
class TestUsersValidation:
|
|
"""Test validation for invalid subactions."""
|
|
|
|
async def test_invalid_subaction_rejected(self, _mock_graphql: AsyncMock) -> None:
|
|
"""Test that non-existent subactions are rejected with clear error."""
|
|
tool_fn = _make_tool()
|
|
with pytest.raises(ToolError, match="Invalid subaction"):
|
|
await tool_fn(action="user", subaction="list")
|
|
|
|
with pytest.raises(ToolError, match="Invalid subaction"):
|
|
await tool_fn(action="user", subaction="add")
|
|
|
|
with pytest.raises(ToolError, match="Invalid subaction"):
|
|
await tool_fn(action="user", subaction="delete")
|
|
|
|
with pytest.raises(ToolError, match="Invalid subaction"):
|
|
await tool_fn(action="user", subaction="cloud")
|
|
|
|
|
|
class TestUsersActions:
|
|
"""Test the single supported subaction: me."""
|
|
|
|
async def test_me(self, _mock_graphql: AsyncMock) -> None:
|
|
"""Test querying current authenticated user."""
|
|
_mock_graphql.return_value = {
|
|
"me": {"id": "u:1", "name": "root", "description": "", "roles": ["ADMIN"]}
|
|
}
|
|
tool_fn = _make_tool()
|
|
result = await tool_fn(action="user", subaction="me")
|
|
assert result["name"] == "root"
|
|
assert result["roles"] == ["ADMIN"]
|
|
_mock_graphql.assert_called_once()
|
|
|
|
|
|
class TestUsersNoneHandling:
|
|
"""Verify subactions return empty dict (not TypeError) when API returns None."""
|
|
|
|
async def test_me_returns_none(self, _mock_graphql: AsyncMock) -> None:
|
|
"""Test that me returns empty dict when API returns None."""
|
|
_mock_graphql.return_value = {"me": None}
|
|
tool_fn = _make_tool()
|
|
result = await tool_fn(action="user", subaction="me")
|
|
assert result == {}
|