mirror of
https://github.com/jmagar/unraid-mcp.git
synced 2026-03-01 16:04:24 -08:00
Comprehensive fixes across Python code, shell scripts, and documentation addressing all remaining MEDIUM and LOW priority review comments. Python Code Fixes (27 fixes): - tools/info.py: Simplified dispatch with lookup tables, defensive guards, CPU fallback formatting, !s conversion flags, module-level sync assertion - tools/docker.py: Case-insensitive container ID regex, keyword-only confirm, module-level ALL_ACTIONS constant - tools/virtualization.py: Normalized single-VM dict responses, unified list/details queries - core/client.py: Fixed HTTP client singleton race condition, compound key substring matching for sensitive data redaction - subscriptions/: Extracted SSL context creation to shared helper in utils.py, replaced deprecated ssl._create_unverified_context API - tools/array.py: Renamed parity_history to parity_status, hoisted ALL_ACTIONS - tools/storage.py: Fixed dict(None) risks, temperature 0 falsiness bug - tools/notifications.py, keys.py, rclone.py: Fixed dict(None) TypeError risks - tests/: Fixed generator type annotations, added coverage for compound keys Shell Script Fixes (13 fixes): - dashboard.sh: Dynamic server discovery, conditional debug output, null-safe jq, notification count guard order, removed unused variables - unraid-query.sh: Proper JSON escaping via jq, --ignore-errors and --insecure CLI flags, TLS verification now on by default - validate-marketplace.sh: Removed unused YELLOW variable, defensive jq, simplified repository URL output Documentation Fixes (24+ fixes): - Version consistency: Updated all references to v0.2.0 across pyproject.toml, plugin.json, marketplace.json, MARKETPLACE.md, __init__.py, README files - Tool count updates: Changed all "26 tools" references to "10 tools, 90 actions" - Markdown lint: Fixed MD022, MD031, MD047 issues across multiple files - Research docs: Fixed auth headers, removed web artifacts, corrected stale info - Skills docs: Fixed query examples, endpoint counts, env var references All 227 tests pass, ruff and ty checks clean.
152 lines
5.1 KiB
Python
152 lines
5.1 KiB
Python
"""Virtual machine management.
|
|
|
|
Provides the `unraid_vm` tool with 9 actions for VM lifecycle management
|
|
including start, stop, pause, resume, force stop, reboot, and reset.
|
|
"""
|
|
|
|
from typing import Any, Literal
|
|
|
|
from fastmcp import FastMCP
|
|
|
|
from ..config.logging import logger
|
|
from ..core.client import make_graphql_request
|
|
from ..core.exceptions import ToolError
|
|
|
|
|
|
QUERIES: dict[str, str] = {
|
|
"list": """
|
|
query ListVMs {
|
|
vms { id domains { id name state uuid } }
|
|
}
|
|
""",
|
|
}
|
|
|
|
MUTATIONS: dict[str, str] = {
|
|
"start": """
|
|
mutation StartVM($id: PrefixedID!) { vm { start(id: $id) } }
|
|
""",
|
|
"stop": """
|
|
mutation StopVM($id: PrefixedID!) { vm { stop(id: $id) } }
|
|
""",
|
|
"pause": """
|
|
mutation PauseVM($id: PrefixedID!) { vm { pause(id: $id) } }
|
|
""",
|
|
"resume": """
|
|
mutation ResumeVM($id: PrefixedID!) { vm { resume(id: $id) } }
|
|
""",
|
|
"force_stop": """
|
|
mutation ForceStopVM($id: PrefixedID!) { vm { forceStop(id: $id) } }
|
|
""",
|
|
"reboot": """
|
|
mutation RebootVM($id: PrefixedID!) { vm { reboot(id: $id) } }
|
|
""",
|
|
"reset": """
|
|
mutation ResetVM($id: PrefixedID!) { vm { reset(id: $id) } }
|
|
""",
|
|
}
|
|
|
|
# Map action names to GraphQL field names (only where they differ)
|
|
_MUTATION_FIELDS: dict[str, str] = {
|
|
"force_stop": "forceStop",
|
|
}
|
|
|
|
DESTRUCTIVE_ACTIONS = {"force_stop", "reset"}
|
|
|
|
VM_ACTIONS = Literal[
|
|
"list", "details",
|
|
"start", "stop", "pause", "resume", "force_stop", "reboot", "reset",
|
|
]
|
|
|
|
|
|
def register_vm_tool(mcp: FastMCP) -> None:
|
|
"""Register the unraid_vm tool with the FastMCP instance."""
|
|
|
|
@mcp.tool()
|
|
async def unraid_vm(
|
|
action: VM_ACTIONS,
|
|
vm_id: str | None = None,
|
|
confirm: bool = False,
|
|
) -> dict[str, Any]:
|
|
"""Manage Unraid virtual machines.
|
|
|
|
Actions:
|
|
list - List all VMs with state
|
|
details - Detailed info for a VM (requires vm_id: UUID, PrefixedID, or name)
|
|
start - Start a VM (requires vm_id)
|
|
stop - Gracefully stop a VM (requires vm_id)
|
|
pause - Pause a VM (requires vm_id)
|
|
resume - Resume a paused VM (requires vm_id)
|
|
force_stop - Force stop a VM (requires vm_id, confirm=True)
|
|
reboot - Reboot a VM (requires vm_id)
|
|
reset - Reset a VM (requires vm_id, confirm=True)
|
|
"""
|
|
all_actions = set(QUERIES) | set(MUTATIONS) | {"details"}
|
|
if action not in all_actions:
|
|
raise ToolError(f"Invalid action '{action}'. Must be one of: {sorted(all_actions)}")
|
|
|
|
if action != "list" and not vm_id:
|
|
raise ToolError(f"vm_id is required for '{action}' action")
|
|
|
|
if action in DESTRUCTIVE_ACTIONS and not confirm:
|
|
raise ToolError(f"Action '{action}' is destructive. Set confirm=True to proceed.")
|
|
|
|
try:
|
|
logger.info(f"Executing unraid_vm action={action}")
|
|
|
|
if action in ("list", "details"):
|
|
data = await make_graphql_request(QUERIES["list"])
|
|
if data.get("vms"):
|
|
vms = data["vms"].get("domains") or data["vms"].get("domain") or []
|
|
if isinstance(vms, dict):
|
|
vms = [vms]
|
|
|
|
if action == "list":
|
|
return {"vms": vms}
|
|
|
|
# details: find specific VM
|
|
for vm in vms:
|
|
if (
|
|
vm.get("uuid") == vm_id
|
|
or vm.get("id") == vm_id
|
|
or vm.get("name") == vm_id
|
|
):
|
|
return dict(vm)
|
|
available = [
|
|
f"{v.get('name')} (UUID: {v.get('uuid')})" for v in vms
|
|
]
|
|
raise ToolError(
|
|
f"VM '{vm_id}' not found. Available: {', '.join(available)}"
|
|
)
|
|
if action == "details":
|
|
raise ToolError("No VM data returned from server")
|
|
return {"vms": []}
|
|
|
|
# Mutations
|
|
if action in MUTATIONS:
|
|
data = await make_graphql_request(
|
|
MUTATIONS[action], {"id": vm_id}
|
|
)
|
|
field = _MUTATION_FIELDS.get(action, action)
|
|
if data.get("vm") and field in data["vm"]:
|
|
return {
|
|
"success": data["vm"][field],
|
|
"action": action,
|
|
"vm_id": vm_id,
|
|
}
|
|
raise ToolError(f"Failed to {action} VM or unexpected response")
|
|
|
|
raise ToolError(f"Unhandled action '{action}' — this is a bug")
|
|
|
|
except ToolError:
|
|
raise
|
|
except Exception as e:
|
|
logger.error(f"Error in unraid_vm action={action}: {e}", exc_info=True)
|
|
msg = str(e)
|
|
if "VMs are not available" in msg:
|
|
raise ToolError(
|
|
"VMs not available on this server. Check VM support is enabled."
|
|
) from e
|
|
raise ToolError(f"Failed to execute vm/{action}: {msg}") from e
|
|
|
|
logger.info("VM tool registered successfully")
|