mirror of
https://github.com/jmagar/unraid-mcp.git
synced 2026-03-01 16:04:24 -08:00
37e9424a5c
Comprehensive fixes across Python code, shell scripts, and documentation addressing all remaining MEDIUM and LOW priority review comments. Python Code Fixes (27 fixes): - tools/info.py: Simplified dispatch with lookup tables, defensive guards, CPU fallback formatting, !s conversion flags, module-level sync assertion - tools/docker.py: Case-insensitive container ID regex, keyword-only confirm, module-level ALL_ACTIONS constant - tools/virtualization.py: Normalized single-VM dict responses, unified list/details queries - core/client.py: Fixed HTTP client singleton race condition, compound key substring matching for sensitive data redaction - subscriptions/: Extracted SSL context creation to shared helper in utils.py, replaced deprecated ssl._create_unverified_context API - tools/array.py: Renamed parity_history to parity_status, hoisted ALL_ACTIONS - tools/storage.py: Fixed dict(None) risks, temperature 0 falsiness bug - tools/notifications.py, keys.py, rclone.py: Fixed dict(None) TypeError risks - tests/: Fixed generator type annotations, added coverage for compound keys Shell Script Fixes (13 fixes): - dashboard.sh: Dynamic server discovery, conditional debug output, null-safe jq, notification count guard order, removed unused variables - unraid-query.sh: Proper JSON escaping via jq, --ignore-errors and --insecure CLI flags, TLS verification now on by default - validate-marketplace.sh: Removed unused YELLOW variable, defensive jq, simplified repository URL output Documentation Fixes (24+ fixes): - Version consistency: Updated all references to v0.2.0 across pyproject.toml, plugin.json, marketplace.json, MARKETPLACE.md, __init__.py, README files - Tool count updates: Changed all "26 tools" references to "10 tools, 90 actions" - Markdown lint: Fixed MD022, MD031, MD047 issues across multiple files - Research docs: Fixed auth headers, removed web artifacts, corrected stale info - Skills docs: Fixed query examples, endpoint counts, env var references All 227 tests pass, ruff and ty checks clean.
86 lines
2.8 KiB
Bash
Executable File
86 lines
2.8 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Validate Claude Code marketplace and plugin structure
|
|
|
|
set -euo pipefail
|
|
|
|
# Colors for output
|
|
RED='\033[0;31m'
|
|
GREEN='\033[0;32m'
|
|
NC='\033[0m' # No Color
|
|
|
|
# Counters
|
|
CHECKS=0
|
|
PASSED=0
|
|
FAILED=0
|
|
|
|
check() {
|
|
local test_name="$1"
|
|
local test_cmd="$2"
|
|
|
|
CHECKS=$((CHECKS + 1))
|
|
echo -n "Checking: $test_name... "
|
|
|
|
if eval "$test_cmd" > /dev/null 2>&1; then
|
|
echo -e "${GREEN}✓${NC}"
|
|
PASSED=$((PASSED + 1))
|
|
return 0
|
|
else
|
|
echo -e "${RED}✗${NC}"
|
|
FAILED=$((FAILED + 1))
|
|
return 1
|
|
fi
|
|
}
|
|
|
|
echo "=== Validating Claude Code Marketplace Structure ==="
|
|
echo ""
|
|
|
|
# Check marketplace manifest
|
|
check "Marketplace manifest exists" "test -f .claude-plugin/marketplace.json"
|
|
check "Marketplace manifest is valid JSON" "jq empty .claude-plugin/marketplace.json"
|
|
check "Marketplace has name" "jq -e '.name' .claude-plugin/marketplace.json"
|
|
check "Marketplace has plugins array" "jq -e '.plugins | type == \"array\"' .claude-plugin/marketplace.json"
|
|
|
|
# Check plugin manifest
|
|
check "Plugin manifest exists" "test -f skills/unraid/.claude-plugin/plugin.json"
|
|
check "Plugin manifest is valid JSON" "jq empty skills/unraid/.claude-plugin/plugin.json"
|
|
check "Plugin has name" "jq -e '.name' skills/unraid/.claude-plugin/plugin.json"
|
|
check "Plugin has version" "jq -e '.version' skills/unraid/.claude-plugin/plugin.json"
|
|
|
|
# Check plugin structure
|
|
check "Plugin has SKILL.md" "test -f skills/unraid/SKILL.md"
|
|
check "Plugin has README.md" "test -f skills/unraid/README.md"
|
|
check "Plugin has scripts directory" "test -d skills/unraid/scripts"
|
|
check "Plugin has examples directory" "test -d skills/unraid/examples"
|
|
check "Plugin has references directory" "test -d skills/unraid/references"
|
|
|
|
# Validate plugin is listed in marketplace
|
|
check "Plugin listed in marketplace" "jq -e '.plugins[] | select(.name == \"unraid\")' .claude-plugin/marketplace.json"
|
|
|
|
# Check marketplace metadata
|
|
check "Marketplace has repository" "jq -e '.repository' .claude-plugin/marketplace.json"
|
|
check "Marketplace has owner" "jq -e '.owner' .claude-plugin/marketplace.json"
|
|
|
|
# Verify source path
|
|
PLUGIN_SOURCE=$(jq -r '.plugins[]? | select(.name == "unraid") | .source // empty' .claude-plugin/marketplace.json 2>/dev/null || true)
|
|
if [ -n "$PLUGIN_SOURCE" ]; then
|
|
check "Plugin source path is valid" "test -d \"$PLUGIN_SOURCE\""
|
|
else
|
|
CHECKS=$((CHECKS + 1))
|
|
FAILED=$((FAILED + 1))
|
|
echo -e "Checking: Plugin source path is valid... ${RED}✗${NC} (plugin not found in marketplace)"
|
|
fi
|
|
|
|
echo ""
|
|
echo "=== Results ==="
|
|
echo -e "Total checks: $CHECKS"
|
|
echo -e "${GREEN}Passed: $PASSED${NC}"
|
|
if [ $FAILED -gt 0 ]; then
|
|
echo -e "${RED}Failed: $FAILED${NC}"
|
|
exit 1
|
|
else
|
|
echo -e "${GREEN}All checks passed!${NC}"
|
|
echo ""
|
|
echo "Marketplace is ready for distribution at:"
|
|
echo " $(jq -r '.repository' .claude-plugin/marketplace.json)"
|
|
fi
|