mirror of
https://github.com/jmagar/unraid-mcp.git
synced 2026-03-01 16:04:24 -08:00
184b8aca1c
**Critical Fixes (7 issues):**
- Fix GraphQL schema field names in users tool (role→roles, remove email)
- Fix GraphQL mutation signatures (addUserInput, deleteUser input)
- Fix dict(None) TypeError guards in users tool (use `or {}` pattern)
- Fix FastAPI version constraint (0.116.1→0.115.0)
- Fix WebSocket SSL context handling (support CA bundles, bool, and None)
- Fix critical disk threshold treated as warning (split counters)
**High Priority Fixes (11 issues):**
- Fix Docker update/remove action response field mapping
- Fix path traversal vulnerability in log validation (normalize paths)
- Fix deleteApiKeys validation (check response before success)
- Fix rclone create_remote validation (check response)
- Fix keys input_data type annotation (dict[str, Any])
- Fix VM domain/domains fallback restoration
**Changes by file:**
- unraid_mcp/tools/docker.py: Response field mapping
- unraid_mcp/tools/info.py: Split critical/warning counters
- unraid_mcp/tools/storage.py: Path normalization for traversal protection
- unraid_mcp/tools/users.py: GraphQL schema + null handling
- unraid_mcp/tools/keys.py: Validation + type annotations
- unraid_mcp/tools/rclone.py: Response validation
- unraid_mcp/tools/virtualization.py: Domain fallback
- unraid_mcp/subscriptions/manager.py: SSL context creation
- pyproject.toml: FastAPI version fix
- tests/*: New tests for all fixes
**Review threads resolved:**
PRRT_kwDOO6Hdxs5uu70L, PRRT_kwDOO6Hdxs5uu70O, PRRT_kwDOO6Hdxs5uu70V,
PRRT_kwDOO6Hdxs5uu70e, PRRT_kwDOO6Hdxs5uu70i, PRRT_kwDOO6Hdxs5uu7zn,
PRRT_kwDOO6Hdxs5uu7z_, PRRT_kwDOO6Hdxs5uu7sI, PRRT_kwDOO6Hdxs5uu7sJ,
PRRT_kwDOO6Hdxs5uu7sK, PRRT_kwDOO6Hdxs5uu7Tk, PRRT_kwDOO6Hdxs5uu7Tn,
PRRT_kwDOO6Hdxs5uu7Tr, PRRT_kwDOO6Hdxs5uu7Ts, PRRT_kwDOO6Hdxs5uu7Tu,
PRRT_kwDOO6Hdxs5uu7Tv, PRRT_kwDOO6Hdxs5uu7Tw, PRRT_kwDOO6Hdxs5uu7Tx
All tests passing.
Co-authored-by: docker-fixer <agent@pr-fixes>
Co-authored-by: info-fixer <agent@pr-fixes>
Co-authored-by: storage-fixer <agent@pr-fixes>
Co-authored-by: users-fixer <agent@pr-fixes>
Co-authored-by: config-fixer <agent@pr-fixes>
Co-authored-by: websocket-fixer <agent@pr-fixes>
Co-authored-by: keys-rclone-fixer <agent@pr-fixes>
Co-authored-by: vm-fixer <agent@pr-fixes>
81 lines
2.7 KiB
Bash
Executable File
81 lines
2.7 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Validate Claude Code marketplace and plugin structure
|
|
|
|
set -euo pipefail
|
|
|
|
# Colors for output
|
|
RED='\033[0;31m'
|
|
GREEN='\033[0;32m'
|
|
YELLOW='\033[1;33m'
|
|
NC='\033[0m' # No Color
|
|
|
|
# Counters
|
|
CHECKS=0
|
|
PASSED=0
|
|
FAILED=0
|
|
|
|
check() {
|
|
local test_name="$1"
|
|
local test_cmd="$2"
|
|
|
|
CHECKS=$((CHECKS + 1))
|
|
echo -n "Checking: $test_name... "
|
|
|
|
if eval "$test_cmd" > /dev/null 2>&1; then
|
|
echo -e "${GREEN}✓${NC}"
|
|
PASSED=$((PASSED + 1))
|
|
return 0
|
|
else
|
|
echo -e "${RED}✗${NC}"
|
|
FAILED=$((FAILED + 1))
|
|
return 1
|
|
fi
|
|
}
|
|
|
|
echo "=== Validating Claude Code Marketplace Structure ==="
|
|
echo ""
|
|
|
|
# Check marketplace manifest
|
|
check "Marketplace manifest exists" "test -f .claude-plugin/marketplace.json"
|
|
check "Marketplace manifest is valid JSON" "jq empty .claude-plugin/marketplace.json"
|
|
check "Marketplace has name" "jq -e '.name' .claude-plugin/marketplace.json"
|
|
check "Marketplace has plugins array" "jq -e '.plugins | type == \"array\"' .claude-plugin/marketplace.json"
|
|
|
|
# Check plugin manifest
|
|
check "Plugin manifest exists" "test -f skills/unraid/.claude-plugin/plugin.json"
|
|
check "Plugin manifest is valid JSON" "jq empty skills/unraid/.claude-plugin/plugin.json"
|
|
check "Plugin has name" "jq -e '.name' skills/unraid/.claude-plugin/plugin.json"
|
|
check "Plugin has version" "jq -e '.version' skills/unraid/.claude-plugin/plugin.json"
|
|
|
|
# Check plugin structure
|
|
check "Plugin has SKILL.md" "test -f skills/unraid/SKILL.md"
|
|
check "Plugin has README.md" "test -f skills/unraid/README.md"
|
|
check "Plugin has scripts directory" "test -d skills/unraid/scripts"
|
|
check "Plugin has examples directory" "test -d skills/unraid/examples"
|
|
check "Plugin has references directory" "test -d skills/unraid/references"
|
|
|
|
# Validate plugin is listed in marketplace
|
|
check "Plugin listed in marketplace" "jq -e '.plugins[] | select(.name == \"unraid\")' .claude-plugin/marketplace.json"
|
|
|
|
# Check marketplace metadata
|
|
check "Marketplace has repository" "jq -e '.repository' .claude-plugin/marketplace.json"
|
|
check "Marketplace has owner" "jq -e '.owner' .claude-plugin/marketplace.json"
|
|
|
|
# Verify source path
|
|
PLUGIN_SOURCE=$(jq -r '.plugins[] | select(.name == "unraid") | .source' .claude-plugin/marketplace.json)
|
|
check "Plugin source path is valid" "test -d \"$PLUGIN_SOURCE\""
|
|
|
|
echo ""
|
|
echo "=== Results ==="
|
|
echo -e "Total checks: $CHECKS"
|
|
echo -e "${GREEN}Passed: $PASSED${NC}"
|
|
if [ $FAILED -gt 0 ]; then
|
|
echo -e "${RED}Failed: $FAILED${NC}"
|
|
exit 1
|
|
else
|
|
echo -e "${GREEN}All checks passed!${NC}"
|
|
echo ""
|
|
echo "Marketplace is ready for distribution at:"
|
|
echo " https://github.com/$(jq -r '.repository' .claude-plugin/marketplace.json | sed 's|https://github.com/||')"
|
|
fi
|