mirror of
https://github.com/jmagar/unraid-mcp.git
synced 2026-03-01 16:04:24 -08:00
Addresses issues found by 4 parallel review agents (code-reviewer,
silent-failure-hunter, type-design-analyzer, pr-test-analyzer).
Source fixes:
- core/utils.py: add public safe_display_url() (moved from tools/health.py)
- core/client.py: rename _redact_sensitive → redact_sensitive (public API)
- core/types.py: add SubscriptionData.__post_init__ for tz-aware datetime
enforcement; remove 6 unused type aliases (SystemHealth, APIResponse, etc.)
- subscriptions/manager.py: add exc_info=True to both except-Exception blocks;
add except ValueError break-on-config-error before retry loop; import
redact_sensitive by new public name
- subscriptions/resources.py: re-raise in autostart_subscriptions() so
ensure_subscriptions_started() doesn't permanently set _subscriptions_started
- subscriptions/diagnostics.py: except ToolError: raise before broad except;
use safe_display_url() instead of raw URL slice
- tools/health.py: move _safe_display_url to core/utils; add exc_info=True;
raise ToolError (not return dict) on ImportError
- tools/info.py: use get_args(INFO_ACTIONS) instead of INFO_ACTIONS.__args__
- tools/{array,docker,keys,notifications,rclone,storage,virtualization}.py:
add Literal-vs-ALL_ACTIONS sync check at import time
Test fixes:
- test_health.py: import safe_display_url from core.utils; update
test_diagnose_import_error_internal to expect ToolError (not error dict)
- test_storage.py: add 3 safe_get tests for zero/False/empty-string values
- test_subscription_manager.py: add TestCapLogContentSingleMassiveLine (2 tests)
- test_client.py: rename _redact_sensitive → redact_sensitive; add tests for
new sensitive keys and is_cacheable explicit-keyword form
170 lines
5.8 KiB
Python
170 lines
5.8 KiB
Python
"""Virtual machine management.
|
|
|
|
Provides the `unraid_vm` tool with 9 actions for VM lifecycle management
|
|
including start, stop, pause, resume, force stop, reboot, and reset.
|
|
"""
|
|
|
|
from typing import Any, Literal, get_args
|
|
|
|
from fastmcp import FastMCP
|
|
|
|
from ..config.logging import logger
|
|
from ..core.client import make_graphql_request
|
|
from ..core.exceptions import ToolError, tool_error_handler
|
|
|
|
|
|
QUERIES: dict[str, str] = {
|
|
"list": """
|
|
query ListVMs {
|
|
vms { id domains { id name state uuid } }
|
|
}
|
|
""",
|
|
# NOTE: The Unraid GraphQL API does not expose a single-VM query.
|
|
# The details query is identical to list; client-side filtering is required.
|
|
"details": """
|
|
query ListVMs {
|
|
vms { id domains { id name state uuid } }
|
|
}
|
|
""",
|
|
}
|
|
|
|
MUTATIONS: dict[str, str] = {
|
|
"start": """
|
|
mutation StartVM($id: PrefixedID!) { vm { start(id: $id) } }
|
|
""",
|
|
"stop": """
|
|
mutation StopVM($id: PrefixedID!) { vm { stop(id: $id) } }
|
|
""",
|
|
"pause": """
|
|
mutation PauseVM($id: PrefixedID!) { vm { pause(id: $id) } }
|
|
""",
|
|
"resume": """
|
|
mutation ResumeVM($id: PrefixedID!) { vm { resume(id: $id) } }
|
|
""",
|
|
"force_stop": """
|
|
mutation ForceStopVM($id: PrefixedID!) { vm { forceStop(id: $id) } }
|
|
""",
|
|
"reboot": """
|
|
mutation RebootVM($id: PrefixedID!) { vm { reboot(id: $id) } }
|
|
""",
|
|
"reset": """
|
|
mutation ResetVM($id: PrefixedID!) { vm { reset(id: $id) } }
|
|
""",
|
|
}
|
|
|
|
# Map action names to GraphQL field names (only where they differ)
|
|
_MUTATION_FIELDS: dict[str, str] = {
|
|
"force_stop": "forceStop",
|
|
}
|
|
|
|
DESTRUCTIVE_ACTIONS = {"force_stop", "reset"}
|
|
|
|
VM_ACTIONS = Literal[
|
|
"list",
|
|
"details",
|
|
"start",
|
|
"stop",
|
|
"pause",
|
|
"resume",
|
|
"force_stop",
|
|
"reboot",
|
|
"reset",
|
|
]
|
|
|
|
ALL_ACTIONS = set(QUERIES) | set(MUTATIONS)
|
|
|
|
if set(get_args(VM_ACTIONS)) != ALL_ACTIONS:
|
|
_missing = ALL_ACTIONS - set(get_args(VM_ACTIONS))
|
|
_extra = set(get_args(VM_ACTIONS)) - ALL_ACTIONS
|
|
raise RuntimeError(
|
|
f"VM_ACTIONS and ALL_ACTIONS are out of sync. "
|
|
f"Missing from Literal: {_missing or 'none'}. Extra in Literal: {_extra or 'none'}"
|
|
)
|
|
|
|
|
|
def register_vm_tool(mcp: FastMCP) -> None:
|
|
"""Register the unraid_vm tool with the FastMCP instance."""
|
|
|
|
@mcp.tool()
|
|
async def unraid_vm(
|
|
action: VM_ACTIONS,
|
|
vm_id: str | None = None,
|
|
confirm: bool = False,
|
|
) -> dict[str, Any]:
|
|
"""Manage Unraid virtual machines.
|
|
|
|
Actions:
|
|
list - List all VMs with state
|
|
details - Detailed info for a VM (requires vm_id: UUID, PrefixedID, or name)
|
|
start - Start a VM (requires vm_id)
|
|
stop - Gracefully stop a VM (requires vm_id)
|
|
pause - Pause a VM (requires vm_id)
|
|
resume - Resume a paused VM (requires vm_id)
|
|
force_stop - Force stop a VM (requires vm_id, confirm=True)
|
|
reboot - Reboot a VM (requires vm_id)
|
|
reset - Reset a VM (requires vm_id, confirm=True)
|
|
"""
|
|
if action not in ALL_ACTIONS:
|
|
raise ToolError(f"Invalid action '{action}'. Must be one of: {sorted(ALL_ACTIONS)}")
|
|
|
|
if action != "list" and not vm_id:
|
|
raise ToolError(f"vm_id is required for '{action}' action")
|
|
|
|
if action in DESTRUCTIVE_ACTIONS and not confirm:
|
|
raise ToolError(f"Action '{action}' is destructive. Set confirm=True to proceed.")
|
|
|
|
with tool_error_handler("vm", action, logger):
|
|
try:
|
|
logger.info(f"Executing unraid_vm action={action}")
|
|
|
|
if action == "list":
|
|
data = await make_graphql_request(QUERIES["list"])
|
|
if data.get("vms"):
|
|
vms = data["vms"].get("domains") or data["vms"].get("domain") or []
|
|
if isinstance(vms, dict):
|
|
vms = [vms]
|
|
return {"vms": vms}
|
|
return {"vms": []}
|
|
|
|
if action == "details":
|
|
data = await make_graphql_request(QUERIES["details"])
|
|
if not data.get("vms"):
|
|
raise ToolError("No VM data returned from server")
|
|
vms = data["vms"].get("domains") or data["vms"].get("domain") or []
|
|
if isinstance(vms, dict):
|
|
vms = [vms]
|
|
for vm in vms:
|
|
if (
|
|
vm.get("uuid") == vm_id
|
|
or vm.get("id") == vm_id
|
|
or vm.get("name") == vm_id
|
|
):
|
|
return dict(vm)
|
|
available = [f"{v.get('name')} (UUID: {v.get('uuid')})" for v in vms]
|
|
raise ToolError(f"VM '{vm_id}' not found. Available: {', '.join(available)}")
|
|
|
|
# Mutations
|
|
if action in MUTATIONS:
|
|
data = await make_graphql_request(MUTATIONS[action], {"id": vm_id})
|
|
field = _MUTATION_FIELDS.get(action, action)
|
|
if data.get("vm") and field in data["vm"]:
|
|
return {
|
|
"success": data["vm"][field],
|
|
"action": action,
|
|
"vm_id": vm_id,
|
|
}
|
|
raise ToolError(f"Failed to {action} VM or unexpected response")
|
|
|
|
raise ToolError(f"Unhandled action '{action}' — this is a bug")
|
|
|
|
except ToolError:
|
|
raise
|
|
except Exception as e:
|
|
if "VMs are not available" in str(e):
|
|
raise ToolError(
|
|
"VMs not available on this server. Check VM support is enabled."
|
|
) from e
|
|
raise
|
|
|
|
logger.info("VM tool registered successfully")
|