mirror of
https://github.com/jmagar/unraid-mcp.git
synced 2026-03-23 20:42:58 -07:00
2b777be927
Security: - Remove /mnt/ from _ALLOWED_LOG_PREFIXES to prevent Unraid share exposure - Add early .. detection for disk/logs and live/log_tail path validation - Add /boot/ prefix restriction for flash_backup source_path - Use hmac.compare_digest for timing-safe API key verification in server.py - Gate include_traceback on DEBUG log level (no tracebacks in production) Correctness: - Re-raise CredentialsNotConfiguredError in health check instead of swallowing - Fix ups_device query (remove non-existent nominalPower/currentPower fields) Best practices (BP-01, BP-05, BP-06): - Add # noqa: ASYNC109 to timeout params in _handle_live and unraid() - Fix start_array* → start_array in docstring (not in ARRAY_DESTRUCTIVE) - Remove from __future__ import annotations from snapshot.py - Replace import-time UNRAID_API_KEY/URL bindings with _settings.ATTR pattern in manager.py, snapshot.py, utils.py, diagnostics.py — fixes stale binding after apply_runtime_config() post-elicitation (BP-05) CI/CD: - Add .github/workflows/ci.yml (5-job pipeline: lint, typecheck, test, version-sync, audit) - Add fail_under = 80 to [tool.coverage.report] - Add version sync check to scripts/validate-marketplace.sh Documentation: - Sync plugin.json version 1.1.1 → 1.1.2 with pyproject.toml - Update CLAUDE.md: 3 tools, system domain count 18, scripts comment fix - Update README.md: 3 tools, security notes - Update docs/AUTHENTICATION.md: H1 title fix - Add UNRAID_CREDENTIALS_DIR to .env.example Bump: 1.1.1 → 1.1.2 Co-Authored-By: Claude <noreply@anthropic.com>
100 lines
3.4 KiB
Bash
Executable File
100 lines
3.4 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Validate Claude Code marketplace and plugin structure
|
|
|
|
set -uo pipefail
|
|
|
|
# Colors for output
|
|
RED='\033[0;31m'
|
|
GREEN='\033[0;32m'
|
|
NC='\033[0m' # No Color
|
|
|
|
# Counters
|
|
CHECKS=0
|
|
PASSED=0
|
|
FAILED=0
|
|
|
|
check() {
|
|
local test_name="$1"
|
|
local test_cmd="$2"
|
|
|
|
CHECKS=$((CHECKS + 1))
|
|
echo -n "Checking: $test_name... "
|
|
|
|
if eval "$test_cmd" > /dev/null 2>&1; then
|
|
echo -e "${GREEN}✓${NC}"
|
|
PASSED=$((PASSED + 1))
|
|
return 0
|
|
else
|
|
echo -e "${RED}✗${NC}"
|
|
FAILED=$((FAILED + 1))
|
|
return 1
|
|
fi
|
|
}
|
|
|
|
echo "=== Validating Claude Code Marketplace Structure ==="
|
|
echo ""
|
|
|
|
# Check marketplace manifest
|
|
check "Marketplace manifest exists" "test -f .claude-plugin/marketplace.json"
|
|
check "Marketplace manifest is valid JSON" "jq empty .claude-plugin/marketplace.json"
|
|
check "Marketplace has name" "jq -e '.name' .claude-plugin/marketplace.json"
|
|
check "Marketplace has plugins array" "jq -e '.plugins | type == \"array\"' .claude-plugin/marketplace.json"
|
|
|
|
# Check plugin manifest
|
|
check "Plugin manifest exists" "test -f .claude-plugin/plugin.json"
|
|
check "Plugin manifest is valid JSON" "jq empty .claude-plugin/plugin.json"
|
|
check "Plugin has name" "jq -e '.name' .claude-plugin/plugin.json"
|
|
check "Plugin has version" "jq -e '.version' .claude-plugin/plugin.json"
|
|
|
|
# Check plugin structure
|
|
check "Plugin has SKILL.md" "test -f skills/unraid/SKILL.md"
|
|
check "Plugin has README.md" "test -f skills/unraid/README.md"
|
|
check "Plugin has scripts directory" "test -d skills/unraid/scripts"
|
|
check "Plugin has examples directory" "test -d skills/unraid/examples"
|
|
check "Plugin has references directory" "test -d skills/unraid/references"
|
|
|
|
# Validate plugin is listed in marketplace
|
|
check "Plugin listed in marketplace" "jq -e '.plugins[] | select(.name == \"unraid\")' .claude-plugin/marketplace.json"
|
|
|
|
# Check marketplace metadata
|
|
check "Marketplace has repository" "jq -e '.repository' .claude-plugin/marketplace.json"
|
|
check "Marketplace has owner" "jq -e '.owner' .claude-plugin/marketplace.json"
|
|
|
|
# Verify source path
|
|
PLUGIN_SOURCE=$(jq -r '.plugins[]? | select(.name == "unraid") | .source // empty' .claude-plugin/marketplace.json 2>/dev/null || true)
|
|
if [ -n "$PLUGIN_SOURCE" ]; then
|
|
check "Plugin source path is valid" "test -d \"$PLUGIN_SOURCE\""
|
|
else
|
|
CHECKS=$((CHECKS + 1))
|
|
FAILED=$((FAILED + 1))
|
|
echo -e "Checking: Plugin source path is valid... ${RED}✗${NC} (plugin not found in marketplace)"
|
|
fi
|
|
|
|
# Check version sync between pyproject.toml and plugin.json
|
|
echo "Checking version sync..."
|
|
TOML_VER=$(grep '^version = ' pyproject.toml | sed 's/version = "//;s/"//')
|
|
PLUGIN_VER=$(python3 -c "import json; print(json.load(open('.claude-plugin/plugin.json'))['version'])" 2>/dev/null || echo "ERROR_READING")
|
|
if [ "$TOML_VER" != "$PLUGIN_VER" ]; then
|
|
echo -e "${RED}FAIL: Version mismatch — pyproject.toml=$TOML_VER, plugin.json=$PLUGIN_VER${NC}"
|
|
CHECKS=$((CHECKS + 1))
|
|
FAILED=$((FAILED + 1))
|
|
else
|
|
echo -e "${GREEN}PASS: Versions in sync ($TOML_VER)${NC}"
|
|
CHECKS=$((CHECKS + 1))
|
|
PASSED=$((PASSED + 1))
|
|
fi
|
|
|
|
echo ""
|
|
echo "=== Results ==="
|
|
echo -e "Total checks: $CHECKS"
|
|
echo -e "${GREEN}Passed: $PASSED${NC}"
|
|
if [ $FAILED -gt 0 ]; then
|
|
echo -e "${RED}Failed: $FAILED${NC}"
|
|
exit 1
|
|
else
|
|
echo -e "${GREEN}All checks passed!${NC}"
|
|
echo ""
|
|
echo "Marketplace is ready for distribution at:"
|
|
echo " $(jq -r '.repository' .claude-plugin/marketplace.json)"
|
|
fi
|