"""Tests for system subactions of the consolidated unraid tool.""" from collections.abc import Generator from unittest.mock import AsyncMock, patch import pytest from conftest import make_tool_fn from unraid_mcp.core.exceptions import ToolError from unraid_mcp.tools.unraid import _analyze_disk_health # --- Unit tests for helper functions --- class TestAnalyzeDiskHealth: def test_counts_healthy_disks(self) -> None: disks = [{"status": "DISK_OK"}, {"status": "DISK_OK"}] result = _analyze_disk_health(disks) assert result["healthy"] == 2 def test_counts_failed_disks(self) -> None: disks = [{"status": "DISK_DSBL"}, {"status": "DISK_INVALID"}] result = _analyze_disk_health(disks) assert result["failed"] == 2 def test_counts_warning_disks(self) -> None: disks = [{"status": "DISK_OK", "warning": 45}] result = _analyze_disk_health(disks) assert result["warning"] == 1 assert result["critical"] == 0 def test_counts_critical_disks(self) -> None: disks = [{"status": "DISK_OK", "critical": 55}] result = _analyze_disk_health(disks) assert result["critical"] == 1 assert result["warning"] == 0 assert result["healthy"] == 0 def test_critical_takes_precedence_over_warning(self) -> None: disks = [{"status": "DISK_OK", "warning": 45, "critical": 55}] result = _analyze_disk_health(disks) assert result["critical"] == 1 assert result["warning"] == 0 def test_counts_missing_disks(self) -> None: disks = [{"status": "DISK_NP"}] result = _analyze_disk_health(disks) assert result["missing"] == 1 def test_empty_list(self) -> None: result = _analyze_disk_health([]) assert result["healthy"] == 0 # --- Integration tests for the tool function --- @pytest.fixture def _mock_graphql() -> Generator[AsyncMock, None, None]: with patch("unraid_mcp.tools.unraid.make_graphql_request", new_callable=AsyncMock) as mock: yield mock def _make_tool(): return make_tool_fn("unraid_mcp.tools.unraid", "register_unraid_tool", "unraid") class TestUnraidInfoTool: async def test_overview_action(self, _mock_graphql: AsyncMock) -> None: _mock_graphql.return_value = { "info": { "os": { "distro": "Unraid", "release": "7.2", "platform": "linux", "arch": "x86_64", "hostname": "test", }, "cpu": {"manufacturer": "Intel", "brand": "i7", "cores": 4, "threads": 8}, } } tool_fn = _make_tool() result = await tool_fn(action="system", subaction="overview") assert "summary" in result _mock_graphql.assert_called_once() async def test_ups_device_requires_device_id(self, _mock_graphql: AsyncMock) -> None: tool_fn = _make_tool() with pytest.raises(ToolError, match="device_id is required"): await tool_fn(action="system", subaction="ups_device") async def test_network_action(self, _mock_graphql: AsyncMock) -> None: _mock_graphql.return_value = { "servers": [ { "id": "s:1", "name": "tootie", "status": "ONLINE", "lanip": "10.1.0.2", "wanip": "", "localurl": "http://10.1.0.2:6969", "remoteurl": "", } ], "vars": { "id": "v:1", "port": 6969, "portssl": 31337, "localTld": "local", "useSsl": None, }, } tool_fn = _make_tool() result = await tool_fn(action="system", subaction="network") assert "accessUrls" in result assert result["httpPort"] == 6969 assert result["httpsPort"] == 31337 assert any(u["type"] == "LAN" and u["ipv4"] == "10.1.0.2" for u in result["accessUrls"]) async def test_connect_action_raises_tool_error(self, _mock_graphql: AsyncMock) -> None: tool_fn = _make_tool() with pytest.raises(ToolError, match="Invalid subaction 'connect'"): await tool_fn(action="system", subaction="connect") async def test_generic_exception_wraps(self, _mock_graphql: AsyncMock) -> None: _mock_graphql.side_effect = RuntimeError("unexpected") tool_fn = _make_tool() with pytest.raises(ToolError, match="Failed to execute system/online"): await tool_fn(action="system", subaction="online") async def test_metrics(self, _mock_graphql: AsyncMock) -> None: _mock_graphql.return_value = { "metrics": {"cpu": {"used": 25.5}, "memory": {"used": 8192, "total": 32768}} } tool_fn = _make_tool() result = await tool_fn(action="system", subaction="metrics") assert result["cpu"]["used"] == 25.5 async def test_services(self, _mock_graphql: AsyncMock) -> None: _mock_graphql.return_value = {"services": [{"name": "docker", "state": "running"}]} tool_fn = _make_tool() result = await tool_fn(action="system", subaction="services") assert "services" in result assert len(result["services"]) == 1 assert result["services"][0]["name"] == "docker" async def test_settings(self, _mock_graphql: AsyncMock) -> None: _mock_graphql.return_value = { "settings": {"unified": {"values": {"timezone": "US/Eastern"}}} } tool_fn = _make_tool() result = await tool_fn(action="system", subaction="settings") assert result["timezone"] == "US/Eastern" async def test_settings_non_dict_values(self, _mock_graphql: AsyncMock) -> None: """Settings values that are not a dict should be wrapped in {'raw': ...}.""" _mock_graphql.return_value = {"settings": {"unified": {"values": "raw_string"}}} tool_fn = _make_tool() result = await tool_fn(action="system", subaction="settings") assert result == {"raw": "raw_string"} async def test_servers(self, _mock_graphql: AsyncMock) -> None: _mock_graphql.return_value = { "servers": [{"id": "s:1", "name": "tower", "status": "online"}] } tool_fn = _make_tool() result = await tool_fn(action="system", subaction="servers") assert "servers" in result assert len(result["servers"]) == 1 assert result["servers"][0]["name"] == "tower" async def test_flash(self, _mock_graphql: AsyncMock) -> None: _mock_graphql.return_value = { "flash": { "id": "f:1", "guid": "abc", "product": "SanDisk", "vendor": "SanDisk", "size": 32000000000, } } tool_fn = _make_tool() result = await tool_fn(action="system", subaction="flash") assert result["product"] == "SanDisk" async def test_ups_devices(self, _mock_graphql: AsyncMock) -> None: _mock_graphql.return_value = { "upsDevices": [{"id": "ups:1", "model": "APC", "status": "online", "charge": 100}] } tool_fn = _make_tool() result = await tool_fn(action="system", subaction="ups_devices") assert "ups_devices" in result assert len(result["ups_devices"]) == 1 assert result["ups_devices"][0]["model"] == "APC" class TestInfoNetworkErrors: """Tests for network-level failures in info operations.""" async def test_overview_http_401_unauthorized(self, _mock_graphql: AsyncMock) -> None: """HTTP 401 Unauthorized should propagate as ToolError.""" _mock_graphql.side_effect = ToolError("HTTP error 401: Unauthorized") tool_fn = _make_tool() with pytest.raises(ToolError, match="401"): await tool_fn(action="system", subaction="overview") async def test_overview_connection_refused(self, _mock_graphql: AsyncMock) -> None: """Connection refused should propagate as ToolError.""" _mock_graphql.side_effect = ToolError( "Network connection error: [Errno 111] Connection refused" ) tool_fn = _make_tool() with pytest.raises(ToolError, match="Connection refused"): await tool_fn(action="system", subaction="overview") async def test_network_json_decode_error(self, _mock_graphql: AsyncMock) -> None: """Invalid JSON from API should propagate as ToolError.""" _mock_graphql.side_effect = ToolError( "Invalid JSON response from Unraid API: Expecting value" ) tool_fn = _make_tool() with pytest.raises(ToolError, match="Invalid JSON"): await tool_fn(action="system", subaction="network") # --------------------------------------------------------------------------- # Regression: removed actions must not be valid subactions # --------------------------------------------------------------------------- @pytest.mark.asyncio @pytest.mark.parametrize("subaction", ["update_server", "update_ssh"]) async def test_removed_info_subactions_are_invalid(subaction: str) -> None: tool_fn = _make_tool() with pytest.raises(ToolError, match="Invalid subaction"): await tool_fn(action="system", subaction=subaction)