fix: address 18 PR review comments (threads 1-18)

Threads 1, 2, 3 — test hygiene:
- Move elicit_and_configure/elicit_reset_confirmation to module-level imports
  in unraid.py so tests can patch at unraid_mcp.tools.unraid.* (thread 2)
- Add return type annotations to _make_tool() in test_customization.py (thread 1)
- Replace unused _mock_ensure_started fixture params with @usefixtures (thread 3)

Thread 4 — remove dead 'connect' subaction from _SYSTEM_QUERIES; the subaction
was always rejected with a ToolError, creating an inconsistent contract.

Thread 5 — centralize two inline "query { online }" strings by reusing
_SYSTEM_QUERIES["online"]; add _DOCKER_QUERIES["_resolve"] for container-name
resolution instead of an inline query literal.

Threads 14, 15, 16, 17, 18 — test improvements:
- test-tools.sh: reword header to "broad non-destructive smoke coverage" (t14)
- test-tools.sh: add _json_payload() helper using jq --arg for safe JSON
  construction; replace all printf-based payloads (thread 15)
- test_input_validation.py: add return type annotations to _make_tool and all
  nested _run_test coroutines (thread 16)
- test_query_validation.py: extract _all_domain_dicts() shared helper to
  eliminate the duplicate 22-item registry (thread 17)
- test_query_validation.py: tighten regression threshold from 50 → 90 (thread 18)

tests/test_health.py

@@ -129,6 +129,11 @@ class TestHealthActions:
         mock_manager.active_subscriptions = {}
         mock_manager.resource_data = {}
 
+        mock_cache = MagicMock()
+        mock_cache.statistics.return_value = MagicMock(call_tool=None)
+        mock_error = MagicMock()
+        mock_error.get_error_stats.return_value = {}
+
         with (
             patch("unraid_mcp.subscriptions.manager.subscription_manager", mock_manager),
             patch("unraid_mcp.subscriptions.resources.ensure_subscriptions_started", AsyncMock()),
@@ -136,10 +141,14 @@ class TestHealthActions:
                 "unraid_mcp.subscriptions.utils._analyze_subscription_status",
                 return_value=(0, []),
             ),
+            patch("unraid_mcp.server.cache_middleware", mock_cache),
+            patch("unraid_mcp.server.error_middleware", mock_error),
         ):
             result = await tool_fn(action="health", subaction="diagnose")
         assert "subscriptions" in result
         assert "summary" in result
+        assert "cache" in result
+        assert "errors" in result
 
     async def test_diagnose_wraps_exception(self, _mock_graphql: AsyncMock) -> None:
         """When subscription manager raises, tool wraps in ToolError."""
@@ -223,7 +232,7 @@ async def test_health_setup_action_calls_elicitation() -> None:
     with (
         patch("unraid_mcp.config.settings.CREDENTIALS_ENV_PATH", mock_path),
         patch(
-            "unraid_mcp.core.setup.elicit_and_configure", new=AsyncMock(return_value=True)
+            "unraid_mcp.tools.unraid.elicit_and_configure", new=AsyncMock(return_value=True)
         ) as mock_elicit,
     ):
         result = await tool_fn(action="health", subaction="setup", ctx=MagicMock())
@@ -242,7 +251,7 @@ async def test_health_setup_action_returns_declined_message() -> None:
 
     with (
         patch("unraid_mcp.config.settings.CREDENTIALS_ENV_PATH", mock_path),
-        patch("unraid_mcp.core.setup.elicit_and_configure", new=AsyncMock(return_value=False)),
+        patch("unraid_mcp.tools.unraid.elicit_and_configure", new=AsyncMock(return_value=False)),
     ):
         result = await tool_fn(action="health", subaction="setup", ctx=MagicMock())
 
@@ -268,10 +277,10 @@ async def test_health_setup_already_configured_and_working_no_reset() -> None:
             new=AsyncMock(return_value={"online": True}),
         ),
         patch(
-            "unraid_mcp.core.setup.elicit_reset_confirmation",
+            "unraid_mcp.tools.unraid.elicit_reset_confirmation",
             new=AsyncMock(return_value=False),
         ),
-        patch("unraid_mcp.core.setup.elicit_and_configure") as mock_configure,
+        patch("unraid_mcp.tools.unraid.elicit_and_configure") as mock_configure,
     ):
         result = await tool_fn(action="health", subaction="setup", ctx=MagicMock())
 
@@ -295,11 +304,11 @@ async def test_health_setup_already_configured_user_confirms_reset() -> None:
             new=AsyncMock(return_value={"online": True}),
         ),
         patch(
-            "unraid_mcp.core.setup.elicit_reset_confirmation",
+            "unraid_mcp.tools.unraid.elicit_reset_confirmation",
             new=AsyncMock(return_value=True),
         ),
         patch(
-            "unraid_mcp.core.setup.elicit_and_configure", new=AsyncMock(return_value=True)
+            "unraid_mcp.tools.unraid.elicit_and_configure", new=AsyncMock(return_value=True)
         ) as mock_configure,
     ):
         result = await tool_fn(action="health", subaction="setup", ctx=MagicMock())
@@ -323,11 +332,11 @@ async def test_health_setup_credentials_exist_but_connection_fails_user_confirms
             new=AsyncMock(side_effect=Exception("connection refused")),
         ),
         patch(
-            "unraid_mcp.core.setup.elicit_reset_confirmation",
+            "unraid_mcp.tools.unraid.elicit_reset_confirmation",
             new=AsyncMock(return_value=True),
         ),
         patch(
-            "unraid_mcp.core.setup.elicit_and_configure", new=AsyncMock(return_value=True)
+            "unraid_mcp.tools.unraid.elicit_and_configure", new=AsyncMock(return_value=True)
         ) as mock_configure,
     ):
         result = await tool_fn(action="health", subaction="setup", ctx=MagicMock())
@@ -351,10 +360,10 @@ async def test_health_setup_credentials_exist_connection_fails_user_declines() -
             new=AsyncMock(side_effect=Exception("connection refused")),
         ),
         patch(
-            "unraid_mcp.core.setup.elicit_reset_confirmation",
+            "unraid_mcp.tools.unraid.elicit_reset_confirmation",
             new=AsyncMock(return_value=False),
         ),
-        patch("unraid_mcp.core.setup.elicit_and_configure") as mock_configure,
+        patch("unraid_mcp.tools.unraid.elicit_and_configure") as mock_configure,
     ):
         result = await tool_fn(action="health", subaction="setup", ctx=MagicMock())
 
@@ -376,7 +385,7 @@ async def test_health_setup_ctx_none_already_configured_returns_no_changes() ->
             "unraid_mcp.tools.unraid.make_graphql_request",
             new=AsyncMock(return_value={"online": True}),
         ),
-        patch("unraid_mcp.core.setup.elicit_and_configure") as mock_configure,
+        patch("unraid_mcp.tools.unraid.elicit_and_configure") as mock_configure,
     ):
         result = await tool_fn(action="health", subaction="setup", ctx=None)
 
@@ -399,7 +408,7 @@ async def test_health_setup_declined_message_includes_manual_path() -> None:
 
     with (
         patch("unraid_mcp.config.settings.CREDENTIALS_ENV_PATH", mock_path),
-        patch("unraid_mcp.core.setup.elicit_and_configure", new=AsyncMock(return_value=False)),
+        patch("unraid_mcp.tools.unraid.elicit_and_configure", new=AsyncMock(return_value=False)),
     ):
         result = await tool_fn(action="health", subaction="setup", ctx=MagicMock())