mirror of
https://github.com/jmagar/unraid-mcp.git
synced 2026-03-01 16:04:24 -08:00
fix: address PR review comments on test suite
- Rename test_start_http_401_unauthorized to test_list_http_401_unauthorized to match the actual action="list" being tested (threads #19, #23) - Use consistent PrefixedID format ("a"*64+":local") in test_start_container instead of "abc123def456"*4 concatenation (thread #37) - Refactor container_actions_require_id to use @pytest.mark.parametrize so each action runs independently (thread #18) - Fix docstring claiming ToolError for test that asserts success in test_stop_mutation_returns_null (thread #26) - Fix inaccurate comment about `in` operator checking truthiness; it checks key existence (thread #25) - Add edge case tests for temperature=0, temperature=null, and logFile=null in test_storage.py (thread #31) Resolves review threads: PRRT_kwDOO6Hdxs5uvO2-, PRRT_kwDOO6Hdxs5uvOcf, PRRT_kwDOO6Hdxs5uu7zx, PRRT_kwDOO6Hdxs5uvO28, PRRT_kwDOO6Hdxs5uvOcp, PRRT_kwDOO6Hdxs5uvOcn, PRRT_kwDOO6Hdxs5uvKr3
This commit is contained in:
@@ -69,11 +69,11 @@ class TestDockerValidation:
|
||||
with pytest.raises(ToolError, match="destructive"):
|
||||
await tool_fn(action="remove", container_id="abc123")
|
||||
|
||||
async def test_container_actions_require_id(self, _mock_graphql: AsyncMock) -> None:
|
||||
@pytest.mark.parametrize("action", ["start", "stop", "details", "logs", "pause", "unpause"])
|
||||
async def test_container_actions_require_id(self, _mock_graphql: AsyncMock, action: str) -> None:
|
||||
tool_fn = _make_tool()
|
||||
for action in ("start", "stop", "details", "logs", "pause", "unpause"):
|
||||
with pytest.raises(ToolError, match="container_id"):
|
||||
await tool_fn(action=action)
|
||||
with pytest.raises(ToolError, match="container_id"):
|
||||
await tool_fn(action=action)
|
||||
|
||||
async def test_network_details_requires_id(self, _mock_graphql: AsyncMock) -> None:
|
||||
tool_fn = _make_tool()
|
||||
@@ -92,18 +92,19 @@ class TestDockerActions:
|
||||
|
||||
async def test_start_container(self, _mock_graphql: AsyncMock) -> None:
|
||||
# First call resolves ID, second performs start
|
||||
cid = "a" * 64 + ":local"
|
||||
_mock_graphql.side_effect = [
|
||||
{
|
||||
"docker": {
|
||||
"containers": [
|
||||
{"id": "abc123def456" * 4 + "abcd1234abcd1234:local", "names": ["plex"]}
|
||||
{"id": cid, "names": ["plex"]}
|
||||
]
|
||||
}
|
||||
},
|
||||
{
|
||||
"docker": {
|
||||
"start": {
|
||||
"id": "abc123def456" * 4 + "abcd1234abcd1234:local",
|
||||
"id": cid,
|
||||
"state": "running",
|
||||
}
|
||||
}
|
||||
@@ -299,7 +300,7 @@ class TestDockerNetworkErrors:
|
||||
with pytest.raises(ToolError, match="Connection refused"):
|
||||
await tool_fn(action="list")
|
||||
|
||||
async def test_start_http_401_unauthorized(self, _mock_graphql: AsyncMock) -> None:
|
||||
async def test_list_http_401_unauthorized(self, _mock_graphql: AsyncMock) -> None:
|
||||
"""HTTP 401 should propagate as ToolError."""
|
||||
_mock_graphql.side_effect = ToolError("HTTP error 401: Unauthorized")
|
||||
tool_fn = _make_tool()
|
||||
|
||||
Reference in New Issue
Block a user