fix(auth): use setenv('') instead of delenv to prevent dotenv re-injection in tests

This commit is contained in:
Jacob Magar
2026-03-16 10:51:14 -04:00
parent 9e9915b2fa
commit 9754261402
2 changed files with 13 additions and 6 deletions

View File

@@ -16,11 +16,17 @@ def _reload_settings(monkeypatch, overrides: dict) -> Any:
def test_google_auth_defaults_to_empty(monkeypatch):
"""Google auth vars default to empty string when not set."""
monkeypatch.delenv("GOOGLE_CLIENT_ID", raising=False)
monkeypatch.delenv("GOOGLE_CLIENT_SECRET", raising=False)
monkeypatch.delenv("UNRAID_MCP_BASE_URL", raising=False)
monkeypatch.delenv("UNRAID_MCP_JWT_SIGNING_KEY", raising=False)
mod = _reload_settings(monkeypatch, {})
# Use setenv("", "") rather than delenv so dotenv reload can't re-inject values
# from ~/.unraid-mcp/.env (load_dotenv won't override existing env vars).
mod = _reload_settings(
monkeypatch,
{
"GOOGLE_CLIENT_ID": "",
"GOOGLE_CLIENT_SECRET": "",
"UNRAID_MCP_BASE_URL": "",
"UNRAID_MCP_JWT_SIGNING_KEY": "",
},
)
assert mod.GOOGLE_CLIENT_ID == ""
assert mod.GOOGLE_CLIENT_SECRET == ""
assert mod.UNRAID_MCP_BASE_URL == ""