fix: address 5 critical and major PR review issues

- Remove set -e from validate-marketplace.sh to prevent early exit on
  check failures, allowing the summary to always be displayed (PRRT_kwDOO6Hdxs5uvKrc)
- Fix marketplace.json source path to point to skills/unraid instead of
  ./ for correct plugin directory resolution (PRRT_kwDOO6Hdxs5uvKrg)
- Fix misleading trap registration comment in unraid-api-crawl.md and
  add auth note to Apollo Studio URL (PRRT_kwDOO6Hdxs5uvO2t)
- Extract duplicated cleanup-with-error-handling in main.py into
  _run_shutdown_cleanup() helper (PRRT_kwDOO6Hdxs5uvO3A)
- Add input validation to read-logs.sh to prevent GraphQL injection
  via LOG_NAME and LINES parameters (PRRT_kwDOO6Hdxs5uvKrj)

unraid_mcp/tools/virtualization.py

@@ -64,6 +64,8 @@ VM_ACTIONS = Literal[
     "reset",
 ]
 
+ALL_ACTIONS = set(QUERIES) | set(MUTATIONS) | {"details"}
+
 
 def register_vm_tool(mcp: FastMCP) -> None:
     """Register the unraid_vm tool with the FastMCP instance."""
@@ -87,9 +89,8 @@ def register_vm_tool(mcp: FastMCP) -> None:
           reboot - Reboot a VM (requires vm_id)
           reset - Reset a VM (requires vm_id, confirm=True)
         """
-        all_actions = set(QUERIES) | set(MUTATIONS) | {"details"}
-        if action not in all_actions:
-            raise ToolError(f"Invalid action '{action}'. Must be one of: {sorted(all_actions)}")
+        if action not in ALL_ACTIONS:
+            raise ToolError(f"Invalid action '{action}'. Must be one of: {sorted(ALL_ACTIONS)}")
 
         if action != "list" and not vm_id:
             raise ToolError(f"vm_id is required for '{action}' action")