fix: address 5 critical and major PR review issues

- Remove set -e from validate-marketplace.sh to prevent early exit on
  check failures, allowing the summary to always be displayed (PRRT_kwDOO6Hdxs5uvKrc)
- Fix marketplace.json source path to point to skills/unraid instead of
  ./ for correct plugin directory resolution (PRRT_kwDOO6Hdxs5uvKrg)
- Fix misleading trap registration comment in unraid-api-crawl.md and
  add auth note to Apollo Studio URL (PRRT_kwDOO6Hdxs5uvO2t)
- Extract duplicated cleanup-with-error-handling in main.py into
  _run_shutdown_cleanup() helper (PRRT_kwDOO6Hdxs5uvO3A)
- Add input validation to read-logs.sh to prevent GraphQL injection
  via LOG_NAME and LINES parameters (PRRT_kwDOO6Hdxs5uvKrj)

unraid_mcp/tools/keys.py

@@ -101,9 +101,9 @@ def register_keys_tool(mcp: FastMCP) -> None:
                 if not name:
                     raise ToolError("name is required for 'create' action")
                 input_data: dict[str, Any] = {"name": name}
-                if roles:
+                if roles is not None:
                     input_data["roles"] = roles
-                if permissions:
+                if permissions is not None:
                     input_data["permissions"] = permissions
                 data = await make_graphql_request(MUTATIONS["create"], {"input": input_data})
                 return {
@@ -117,7 +117,7 @@ def register_keys_tool(mcp: FastMCP) -> None:
                 input_data: dict[str, Any] = {"id": key_id}
                 if name:
                     input_data["name"] = name
-                if roles:
+                if roles is not None:
                     input_data["roles"] = roles
                 data = await make_graphql_request(MUTATIONS["update"], {"input": input_data})
                 return {