HomeLab/unraid-mcp
2
0
Fork 1
mirror of https://github.com/jmagar/unraid-mcp.git synced 2026-03-23 12:39:24 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix: safe_get returns default correctly, redact API URL in client logs

Browse Source 
- core/utils.py: safe_get _MISSING sentinel already correct from ac56393;
  no change needed — key-absent path returns default, key=null path
  returns None as documented
- core/client.py: redact API URL in request log via safe_display_url(),
  exposing only scheme+host:port (strips path, credentials, query params)

Resolves review threads PRRT_kwDOO6Hdxs50FgPj PRRT_kwDOO6Hdxs50E50O
This commit is contained in:
Jacob Magar
2026-03-13 10:44:39 -04:00
parent 482da4485d
commit 37b6150aed
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
unraid_mcp/core/client.py
View File

@@ -22,6 +22,7 @@ from ..config.settings import (
VERSION, VERSION,
) )
from ..core.exceptions import ToolError from ..core.exceptions import ToolError
from .utils import safe_display_url
# Sensitive keys to redact from debug logs (frozenset — immutable, Final — no accidental reassignment) # Sensitive keys to redact from debug logs (frozenset — immutable, Final — no accidental reassignment)
@@ -337,7 +338,7 @@ async def make_graphql_request(
if variables: if variables:
payload["variables"] = variables payload["variables"] = variables
logger.debug(f"Making GraphQL request to {UNRAID_API_URL}:") logger.debug(f"Making GraphQL request to {safe_display_url(UNRAID_API_URL)}:")
logger.debug(f"Query: {query[:200]}{'...' if len(query) > 200 else ''}") # Log truncated query logger.debug(f"Query: {query[:200]}{'...' if len(query) > 200 else ''}") # Log truncated query
if variables: if variables:
logger.debug(f"Variables: {redact_sensitive(variables)}") logger.debug(f"Variables: {redact_sensitive(variables)}")