mirror of
https://github.com/jmagar/unraid-mcp.git
synced 2026-03-02 00:04:45 -08:00
fix: address 18 CRITICAL+HIGH PR review comments
**Critical Fixes (7 issues):**
- Fix GraphQL schema field names in users tool (role→roles, remove email)
- Fix GraphQL mutation signatures (addUserInput, deleteUser input)
- Fix dict(None) TypeError guards in users tool (use `or {}` pattern)
- Fix FastAPI version constraint (0.116.1→0.115.0)
- Fix WebSocket SSL context handling (support CA bundles, bool, and None)
- Fix critical disk threshold treated as warning (split counters)
**High Priority Fixes (11 issues):**
- Fix Docker update/remove action response field mapping
- Fix path traversal vulnerability in log validation (normalize paths)
- Fix deleteApiKeys validation (check response before success)
- Fix rclone create_remote validation (check response)
- Fix keys input_data type annotation (dict[str, Any])
- Fix VM domain/domains fallback restoration
**Changes by file:**
- unraid_mcp/tools/docker.py: Response field mapping
- unraid_mcp/tools/info.py: Split critical/warning counters
- unraid_mcp/tools/storage.py: Path normalization for traversal protection
- unraid_mcp/tools/users.py: GraphQL schema + null handling
- unraid_mcp/tools/keys.py: Validation + type annotations
- unraid_mcp/tools/rclone.py: Response validation
- unraid_mcp/tools/virtualization.py: Domain fallback
- unraid_mcp/subscriptions/manager.py: SSL context creation
- pyproject.toml: FastAPI version fix
- tests/*: New tests for all fixes
**Review threads resolved:**
PRRT_kwDOO6Hdxs5uu70L, PRRT_kwDOO6Hdxs5uu70O, PRRT_kwDOO6Hdxs5uu70V,
PRRT_kwDOO6Hdxs5uu70e, PRRT_kwDOO6Hdxs5uu70i, PRRT_kwDOO6Hdxs5uu7zn,
PRRT_kwDOO6Hdxs5uu7z_, PRRT_kwDOO6Hdxs5uu7sI, PRRT_kwDOO6Hdxs5uu7sJ,
PRRT_kwDOO6Hdxs5uu7sK, PRRT_kwDOO6Hdxs5uu7Tk, PRRT_kwDOO6Hdxs5uu7Tn,
PRRT_kwDOO6Hdxs5uu7Tr, PRRT_kwDOO6Hdxs5uu7Ts, PRRT_kwDOO6Hdxs5uu7Tu,
PRRT_kwDOO6Hdxs5uu7Tv, PRRT_kwDOO6Hdxs5uu7Tw, PRRT_kwDOO6Hdxs5uu7Tx
All tests passing.
Co-authored-by: docker-fixer <agent@pr-fixes>
Co-authored-by: info-fixer <agent@pr-fixes>
Co-authored-by: storage-fixer <agent@pr-fixes>
Co-authored-by: users-fixer <agent@pr-fixes>
Co-authored-by: config-fixer <agent@pr-fixes>
Co-authored-by: websocket-fixer <agent@pr-fixes>
Co-authored-by: keys-rclone-fixer <agent@pr-fixes>
Co-authored-by: vm-fixer <agent@pr-fixes>
This commit is contained in:
49
skills/unraid/references/endpoints.md
Normal file
49
skills/unraid/references/endpoints.md
Normal file
@@ -0,0 +1,49 @@
|
||||
# Unraid API Endpoints Reference
|
||||
|
||||
Complete list of available GraphQL read-only endpoints in Unraid 7.2+.
|
||||
|
||||
## System & Metrics (8)
|
||||
1. **`info`** - Hardware specs (CPU, OS, motherboard)
|
||||
2. **`metrics`** - Real-time CPU/memory usage
|
||||
3. **`online`** - Server online status
|
||||
4. **`isInitialSetup`** - Setup completion status
|
||||
5. **`config`** - System configuration
|
||||
6. **`vars`** - System variables
|
||||
7. **`settings`** - System settings
|
||||
8. **`logFiles`** - List all log files
|
||||
|
||||
## Storage (4)
|
||||
9. **`array`** - Array status, disks, parity
|
||||
10. **`disks`** - All physical disks (array + cache + USB)
|
||||
11. **`shares`** - Network shares
|
||||
12. **`logFile`** - Read log content
|
||||
|
||||
## Virtualization (2)
|
||||
13. **`docker`** - Docker containers
|
||||
14. **`vms`** - Virtual machines
|
||||
|
||||
## Monitoring (2)
|
||||
15. **`notifications`** - System alerts
|
||||
16. **`upsDevices`** - UPS battery status
|
||||
|
||||
## User & Auth (4)
|
||||
17. **`me`** - Current user info
|
||||
18. **`owner`** - Server owner
|
||||
19. **`isSSOEnabled`** - SSO status
|
||||
20. **`oidcProviders`** - OIDC providers
|
||||
|
||||
## API Management (2)
|
||||
21. **`apiKeys`** - List API keys
|
||||
|
||||
## Customization (3)
|
||||
22. **`customization`** - UI theme & settings
|
||||
23. **`publicTheme`** - Public theme
|
||||
24. **`publicPartnerInfo`** - Partner branding
|
||||
|
||||
## Server Management (3)
|
||||
25. **`registration`** - License info
|
||||
26. **`server`** - Server metadata
|
||||
27. **`servers`** - Multi-server management
|
||||
|
||||
## Bonus (1)
|
||||
28. **`plugins`** - Installed plugins (returns empty array if none)
|
||||
Reference in New Issue
Block a user