HISTORY.md

@@ -5,44 +5,10 @@ Changelog
 (unreleased)
 ------------
 
-Fix
-~~~
-- Improved Spotify auth check flow, refs NOISSUE. [Simon Diesenreiter]
-
-
-0.6.8 (2025-07-20)
-------------------
-
-Fix
-~~~
-- Improved Spotify auth check flow, refs NOISSUE. [Simon Diesenreiter]
-
-Other
-~~~~~
-
-
-0.6.7 (2025-07-20)
-------------------
-
-Fix
-~~~
-- Attempted bugfix for crashing process on invalid spotify access token,
-  refs NOISSUE. [Simon Diesenreiter]
-
-Other
-~~~~~
-
-
-0.6.6 (2025-07-20)
-------------------
-
 Fix
 ~~~
 - Add additional logging, refs NOISSUE. [Simon Diesenreiter]
 
-Other
-~~~~~
-
 
 0.6.5 (2025-07-20)
 ------------------

song_of_the_day/Program.cs

@@ -87,23 +87,21 @@ likePlaylistCheckTimer.OnOccurence += async (s, ea) =>
         if (!await spotifyApiClient.IsUserAuthenticatedAsync(user))
         {
             logger.LogWarning($"User {user.LdapUserName} is not authorized with Spotify - skipping playlist sync");
+            continue;
         }
-        else
+        var foundPlaylist = dci.SmartPlaylistDefinitions?.Where(p => p.CreatedBy == user).ToList().Where(p => p.IsThisUsersLikedSongsPlaylist).SingleOrDefault();
+        if (foundPlaylist == null)
         {
-            var foundPlaylist = dci.SmartPlaylistDefinitions?.Where(p => p.CreatedBy == user).ToList().Where(p => p.IsThisUsersLikedSongsPlaylist).SingleOrDefault();
+            logger.LogWarning($"Creating liked songs playlist for user {user.LdapUserName}");
-            if (foundPlaylist == null)
+            var title = $"{user.PreferredName}'s liked songs";
-            {
+            var description = $"A collection of the songs liked by {user.PreferredName} on their 'Song of the day' server instance.";
-                logger.LogWarning($"Creating liked songs playlist for user {user.LdapUserName}");
+            // playlist does not exist yet, creating it
-                var title = $"{user.PreferredName}'s liked songs";
+            var newPlaylist = await (await spotifyApiClient.WithUserAuthorizationAsync(user)).CreateSpotifyPlaylist(title, description, false, true, user);
-                var description = $"A collection of the songs liked by {user.PreferredName} on their 'Song of the day' server instance.";
+            await playlistSynchronizer.SynchronizePlaylistAsync(newPlaylist);
-                // playlist does not exist yet, creating it
+            needsSaving = true;
-                var newPlaylist = await (await spotifyApiClient.WithUserAuthorizationAsync(user)).CreateSpotifyPlaylist(title, description, false, true, user);
-                await playlistSynchronizer.SynchronizePlaylistAsync(newPlaylist);
-                needsSaving = true;
-            }
-            logger.LogWarning($"Syncing playlists for user {user.LdapUserName}");
-            await playlistSynchronizer.SynchronizeUserPlaylistsAsync(user);
         }
+        logger.LogWarning($"Syncing playlists for user {user.LdapUserName}");
+        await playlistSynchronizer.SynchronizeUserPlaylistsAsync(user);
     }
 
     if (needsSaving)

song_of_the_day/SpotifyIntegration/SpotifyApiClient.cs

@@ -110,7 +110,7 @@ public class SpotifyApiClient
 
     public async Task<string> GetValidAuthorizationTokenAsync(User user)
     {
-        if (string.IsNullOrEmpty(user.SpotifyAuthAccessToken) || string.IsNullOrEmpty(user.SpotifyAuthRefreshToken))
+        if (string.IsNullOrEmpty(user.SpotifyAuthAccessToken))
         {
             // user either never connected Spotify or we failed to refresh token - user needs to re-authenticate
             return string.Empty;

song_of_the_day/VERSION

@@ -1 +1 @@
-0.6.9
+0.6.6