Compare commits

..

6 Commits

Author SHA1 Message Date
187d8e92f0 release: version 0.6.10 🚀
Some checks failed
CI / linter (9.0.X, ubuntu-latest) (push) Failing after 4m17s
CI / tests_linux (9.0.X, ubuntu-latest) (push) Has been skipped
SonarQube Scan / SonarQube Trigger (push) Failing after 6m10s
Build Docker image / Create Release (push) Successful in 40s
Build Docker image / deploy (push) Successful in 12m58s
2025-07-26 16:32:43 +02:00
07c7af4633 fix: proper Spotify token refresh flow, refs: NOISSUE 2025-07-26 16:32:41 +02:00
e38023d790 release: version 0.6.9 🚀
Some checks failed
SonarQube Scan / SonarQube Trigger (push) Has been cancelled
CI / tests_linux (9.0.X, ubuntu-latest) (push) Has been cancelled
CI / linter (9.0.X, ubuntu-latest) (push) Has been cancelled
Build Docker image / Create Release (push) Successful in 44s
Build Docker image / deploy (push) Successful in 1m59s
2025-07-20 17:45:00 +02:00
939ae74e95 fix: improved Spotify auth check flow, refs NOISSUE 2025-07-20 17:44:52 +02:00
95406be062 release: version 0.6.8 🚀
Some checks failed
Build Docker image / Create Release (push) Successful in 22s
CI / linter (9.0.X, ubuntu-latest) (push) Failing after 1m17s
CI / tests_linux (9.0.X, ubuntu-latest) (push) Has been skipped
Build Docker image / deploy (push) Successful in 1m59s
SonarQube Scan / SonarQube Trigger (push) Failing after 4m54s
2025-07-20 17:32:20 +02:00
918ed2e667 fix: improved Spotify auth check flow, refs NOISSUE 2025-07-20 17:32:18 +02:00
4 changed files with 53 additions and 15 deletions

View File

@@ -5,11 +5,44 @@ Changelog
(unreleased) (unreleased)
------------ ------------
Fix
~~~
- Proper Spotify token refresh flow, refs: NOISSUE. [Simon Diesenreiter]
0.6.9 (2025-07-20)
------------------
Fix
~~~
- Improved Spotify auth check flow, refs NOISSUE. [Simon Diesenreiter]
Other
~~~~~
0.6.8 (2025-07-20)
------------------
Fix
~~~
- Improved Spotify auth check flow, refs NOISSUE. [Simon Diesenreiter]
Other
~~~~~
0.6.7 (2025-07-20)
------------------
Fix Fix
~~~ ~~~
- Attempted bugfix for crashing process on invalid spotify access token, - Attempted bugfix for crashing process on invalid spotify access token,
refs NOISSUE. [Simon Diesenreiter] refs NOISSUE. [Simon Diesenreiter]
Other
~~~~~
0.6.6 (2025-07-20) 0.6.6 (2025-07-20)
------------------ ------------------

View File

@@ -87,21 +87,23 @@ likePlaylistCheckTimer.OnOccurence += async (s, ea) =>
if (!await spotifyApiClient.IsUserAuthenticatedAsync(user)) if (!await spotifyApiClient.IsUserAuthenticatedAsync(user))
{ {
logger.LogWarning($"User {user.LdapUserName} is not authorized with Spotify - skipping playlist sync"); logger.LogWarning($"User {user.LdapUserName} is not authorized with Spotify - skipping playlist sync");
continue;
} }
var foundPlaylist = dci.SmartPlaylistDefinitions?.Where(p => p.CreatedBy == user).ToList().Where(p => p.IsThisUsersLikedSongsPlaylist).SingleOrDefault(); else
if (foundPlaylist == null)
{ {
logger.LogWarning($"Creating liked songs playlist for user {user.LdapUserName}"); var foundPlaylist = dci.SmartPlaylistDefinitions?.Where(p => p.CreatedBy == user).ToList().Where(p => p.IsThisUsersLikedSongsPlaylist).SingleOrDefault();
var title = $"{user.PreferredName}'s liked songs"; if (foundPlaylist == null)
var description = $"A collection of the songs liked by {user.PreferredName} on their 'Song of the day' server instance."; {
// playlist does not exist yet, creating it logger.LogWarning($"Creating liked songs playlist for user {user.LdapUserName}");
var newPlaylist = await (await spotifyApiClient.WithUserAuthorizationAsync(user)).CreateSpotifyPlaylist(title, description, false, true, user); var title = $"{user.PreferredName}'s liked songs";
await playlistSynchronizer.SynchronizePlaylistAsync(newPlaylist); var description = $"A collection of the songs liked by {user.PreferredName} on their 'Song of the day' server instance.";
needsSaving = true; // playlist does not exist yet, creating it
var newPlaylist = await (await spotifyApiClient.WithUserAuthorizationAsync(user)).CreateSpotifyPlaylist(title, description, false, true, user);
await playlistSynchronizer.SynchronizePlaylistAsync(newPlaylist);
needsSaving = true;
}
logger.LogWarning($"Syncing playlists for user {user.LdapUserName}");
await playlistSynchronizer.SynchronizeUserPlaylistsAsync(user);
} }
logger.LogWarning($"Syncing playlists for user {user.LdapUserName}");
await playlistSynchronizer.SynchronizeUserPlaylistsAsync(user);
} }
if (needsSaving) if (needsSaving)
@@ -255,7 +257,6 @@ messageSyncTimer.OnOccurence += async (s, ea) =>
// only start interaction timers in production builds // only start interaction timers in production builds
// for local/development testing we want those disabled // for local/development testing we want those disabled
likePlaylistCheckTimer.Start();
if (!app.Environment.IsDevelopment()) if (!app.Environment.IsDevelopment())
{ {
logger.LogTrace("Starting timer for scheduled processes."); logger.LogTrace("Starting timer for scheduled processes.");
@@ -263,6 +264,7 @@ if (!app.Environment.IsDevelopment())
userIntroTimer.Start(); userIntroTimer.Start();
pickOfTheDayTimer.Start(); pickOfTheDayTimer.Start();
ldapAssociationTimer.Start(); ldapAssociationTimer.Start();
likePlaylistCheckTimer.Start();
} }
else else
{ {

View File

@@ -139,7 +139,10 @@ public class SpotifyApiClient
user.SpotifyAuthAccessToken = oAuthResponse.AccessToken; user.SpotifyAuthAccessToken = oAuthResponse.AccessToken;
user.SpotifyAuthExpiresAfterSeconds = oAuthResponse.ExpiresIn; user.SpotifyAuthExpiresAfterSeconds = oAuthResponse.ExpiresIn;
user.SpotifyAuthCreatedAt = oAuthResponse.CreatedAt; user.SpotifyAuthCreatedAt = oAuthResponse.CreatedAt;
user.SpotifyAuthRefreshToken = oAuthResponse.RefreshToken; if (!string.IsNullOrEmpty(oAuthResponse.RefreshToken))
{
user.SpotifyAuthRefreshToken = oAuthResponse.RefreshToken;
}
return user.SpotifyAuthAccessToken; return user.SpotifyAuthAccessToken;
} }
catch (Exception ex) catch (Exception ex)

View File

@@ -1 +1 @@
0.6.7 0.6.10