release: version 0.4.2 🚀

HISTORY.md

@@ -5,6 +5,26 @@ Changelog
 (unreleased)
 ------------
 
+Fix
+~~~
+- Broken build, refs NOISSUE. [Simon Diesenreiter]
+
+
+0.4.1 (2025-06-25)
+------------------
+
+Fix
+~~~
+- Fix formatting, refs NOISSUE. [Simon Diesenreiter]
+- URL type, refs NOISSUE. [simon]
+
+Other
+~~~~~
+
+
+0.4.0 (2025-06-04)
+------------------
+
 Fix
 ~~~
 - Some cleanup and fixing runtime bugs, refs NOISSUE. [Simon
@@ -274,6 +294,10 @@ Other
 0.1.9 (2025-04-15)
 ------------------
 
+
+0.1.8 (2025-04-15)
+------------------
+
 Fix
 ~~~
 - Additional debug outputs refs NOISSUE. [Simon Diesenreiter]

song_of_the_day/MessengerIntegration/SignalIntegration.cs

@@ -3,10 +3,10 @@ using song_of_the_day;
 
 public class LinkPreviewAttachment
 {
-    public string Url { get; set; }
+    public required string Url { get; set; }
-    public string Title { get; set; }
+    public required string Title { get; set; }
-    public string Description { get; set; }
+    public required string Description { get; set; }
-    public string Base64Image { get; set; }
+    public required string Base64Image { get; set; }
 }
 
 public class SignalIntegration

song_of_the_day/Pages/Index.cshtml.cs

@@ -17,13 +17,14 @@ public class IndexModel : PageModel
     [BindProperty]
     public List<SongSuggestion> SongSuggestions { get; set; } = new List<SongSuggestion>();
 
-    public async Task OnGet()
+    public Task OnGet()
     {
         using var dci = DataContext.Instance;
-        this.SongSuggestions = dci.SongSuggestions.OrderByDescending(s => s.Date)
+        SongSuggestions = dci.SongSuggestions.OrderByDescending(s => s.Date)
             .Take(50)
             .Include(s => s.Song)
             .Include(s => s.User)
             .ToList();
+        return Task.CompletedTask;
     }
 }

song_of_the_day/Pages/Shared/SongPartialModel.cs

@@ -1,6 +1,6 @@
 public class SongPartialModel
 {
-    public Song InnerSong { get; set; }
+    public required Song InnerSong { get; set; }
 
     public string? Artist => InnerSong.Artist;
 

song_of_the_day/Pages/SongSubmission.cshtml.cs

@@ -40,7 +40,7 @@ public class SongSubmissionModel : PageModel
     public bool IsPageReadonly { get; set; } = false;
 
     [BindProperty]
-    public SuggestionHelper SuggestionHelper { get; set; } = null;
+    public SuggestionHelper? SuggestionHelper { get; set; } = null;
 
     [BindProperty]
     public List<SongSuggestion> UserSongSubmissions { get; set; } = [];

song_of_the_day/Pages/UnclaimedPhoneNumbers.cshtml.cs

@@ -24,7 +24,7 @@ public class UnclaimedPhoneNumbersModel : PageModel
     {
         using (var dci = DataContext.Instance)
         {
-            this.UnclaimedUsers = dci.Users == null ? new List<User>(): dci.Users.Where(u => string.IsNullOrEmpty(u.LdapUserName)).ToList();
+            this.UnclaimedUsers = dci.Users == null ? new List<User>() : dci.Users.Where(u => string.IsNullOrEmpty(u.LdapUserName)).ToList();
         }
     }
 

song_of_the_day/Program.cs

@@ -152,7 +152,7 @@ pickOfTheDayTimer.OnOccurence += async (s, ea) =>
         await signalIntegration.SendMessageToGroupAsync($"Today's chosen person to share a song is: **{userName}**");
         await signalIntegration.SendMessageToUserAsync($"Congratulations, you have been chosen to share a song today!", signalId);
         await signalIntegration.SendMessageToUserAsync($"Today's (optional) suggestion helper to help you pick a song is:\n\n**{suggestion.Title}**\n\n*{suggestion.Description}*", signalId);
-        await signalIntegration.SendMessageToUserAsync($"Please navigate to https://sord.disi.dev/SongSubmission/{newSongSuggestion.Id} to submit your choice!", luckyUser.SignalMemberId);
+        await signalIntegration.SendMessageToUserAsync($"Please navigate to https://sotd.disi.dev/SongSubmission/{newSongSuggestion.Id} to submit your choice!", luckyUser.SignalMemberId);
     }
     await dci.DisposeAsync();
 };

song_of_the_day/SongValidators/Base64UrlImageBuilder.cs

@@ -1,6 +1,6 @@
 public class Base64UrlImageBuilder
 {
-    public string ContentType { set; get; }
+    public required string ContentType { set; get; }
 
     public string Url
     {
@@ -9,11 +9,17 @@ public class Base64UrlImageBuilder
             var httpClient = new HttpClient();
             var response = (httpClient.GetAsync(new Uri($"{value}"))).Result;
             var bytes = (response.Content.ReadAsByteArrayAsync()).Result;
-            FileContents = Convert.ToBase64String(bytes);
+            _fileContents = Convert.ToBase64String(bytes);
         }
     }
 
-    private string FileContents { get; set; }
+    private string _fileContents = string.Empty;
+
+    public string FileContents { 
+        get {
+            return _fileContents;
+        }
+    } 
 
     public override string ToString()
     {

song_of_the_day/SongValidators/SpotifyValidator.cs

@@ -8,7 +8,7 @@ public class SpotifyValidator : UriBasedSongValidatorBase
     public override string UriValidatorRegex => @"^(https?://)?open.spotify.com/track/([a-zA-Z0-9_-]{22})(\?si=[a-zA-Z0-9_-]+)?$";
 
     public SpotifyValidator(ILogger _logger, SpotifyApiClient spotifyApiClient) : base(_logger, spotifyApiClient)
-    {}
+    { }
 
     public override Task<bool> CanExtractSongMetadataAsync(Uri songUri)
     {

song_of_the_day/SongValidators/UriBasedSongValidatorBase.cs

@@ -5,7 +5,7 @@ public abstract class UriBasedSongValidatorBase : SongValidatorBase
     public abstract string UriValidatorRegex { get; }
 
     public UriBasedSongValidatorBase(ILogger logger, SpotifyApiClient spotifyApiClient) : base(logger, spotifyApiClient)
-    {}
+    { }
 
     public Match GetUriMatch(Uri songUri)
     {

song_of_the_day/SongValidators/YoutubeValidator.cs

@@ -14,9 +14,9 @@ public class YoutubeValidator : UriBasedSongValidatorBase
 
     public override string UriValidatorRegex => @"^(https?://)?(www\.)?(youtube\.com/watch\?v=|youtu\.be/)([a-zA-Z0-9_-]{11})";
 
-    public override async Task<bool> CanExtractSongMetadataAsync(Uri songUri)
+    public override Task<bool> CanExtractSongMetadataAsync(Uri songUri)
     {
-        return this.CanValidateUri(songUri);
+        return Task.FromResult(this.CanValidateUri(songUri));
     }
 
     public override SongProvider GetSongProvider()

song_of_the_day/VERSION

@@ -1 +1 @@
-0.4.0
+0.4.2