diff --git a/www/request_account/index.php b/www/request_account/index.php
index 71b502a..bffd8ef 100644
--- a/www/request_account/index.php
+++ b/www/request_account/index.php
@@ -65,7 +65,7 @@ if($_POST) {
$mail_subject = "$firstname $lastname has requested an account for $ORGANISATION_NAME.";
-$link_url="${SITE_PROTOCOL}${SERVER_HOSTNAME}${SERVER_PATH}account_manager/new_user.php?account_request&first_name=$firstname&last_name=$lastname&email=$email";
+$link_url="{$SITE_PROTOCOL}{$SERVER_HOSTNAME}{$SERVER_PATH}account_manager/new_user.php?account_request&first_name=$firstname&last_name=$lastname&email=$email";
if (!isset($email)) { $email = "n/a"; }
if (!isset($notes)) { $notes = "n/a"; }
diff --git a/www/setup/run_checks.php b/www/setup/run_checks.php
index 7787655..f38434a 100644
--- a/www/setup/run_checks.php
+++ b/www/setup/run_checks.php
@@ -35,14 +35,14 @@ $ldap_connection = open_ldap_connection();
\n";
+print "$li_good Connected to {$LDAP['uri']}\n";
#TLS?
if ($LDAP['connection_type'] != "plain") {
- print "$li_good Encrypted connection to ${LDAP['uri']} via ${LDAP['connection_type']}\n";
+ print "$li_good Encrypted connection to {$LDAP['uri']} via {$LDAP['connection_type']}\n";
}
else {
- print "$li_warn Unable to connect to ${LDAP['uri']} via StartTLS. ";
+ print "$li_warn Unable to connect to {$LDAP['uri']} via StartTLS. ";
print "What's this?\n";
@@ -98,14 +98,14 @@ else {
${LDAP['group_dn']}) doesn't exist. ";
- print ") doesn't exist. ";
+ print "What's this?";
print "";
@@ -114,17 +114,17 @@ if ($group_result['count'] != 1) {
}
else {
- print "$li_good The group OU (${LDAP['group_dn']}) is present.";
+ print "$li_good The group OU ({$LDAP['group_dn']}) is present.";
}
-$user_filter = "(&(objectclass=organizationalUnit)(ou=${LDAP['user_ou']}))";
-$ldap_user_search = ldap_search($ldap_connection, "${LDAP['base_dn']}", $user_filter);
+$user_filter = "(&(objectclass=organizationalUnit)(ou={$LDAP['user_ou']}))";
+$ldap_user_search = ldap_search($ldap_connection, "{$LDAP['base_dn']}", $user_filter);
$user_result = ldap_get_entries($ldap_connection, $ldap_user_search);
if ($user_result['count'] != 1) {
- print "$li_fail The user OU (${LDAP['user_dn']}) doesn't exist. ";
- print ") doesn't exist. ";
+ print "What's this?";
print "";
@@ -133,7 +133,7 @@ if ($user_result['count'] != 1) {
}
else {
- print "$li_good The user OU (${LDAP['user_dn']}) is present.";
+ print "$li_good The user OU ({$LDAP['user_dn']}) is present.";
}
?>
@@ -148,13 +148,13 @@ else {
lastGID entry doesn't exist. ";
- print "What's this?";
print "";
@@ -168,13 +168,13 @@ else {
$uid_filter = "(&(objectclass=device)(cn=lastUID))";
-$ldap_uid_search = ldap_search($ldap_connection, "${LDAP['base_dn']}", $uid_filter);
+$ldap_uid_search = ldap_search($ldap_connection, "{$LDAP['base_dn']}", $uid_filter);
$uid_result = ldap_get_entries($ldap_connection, $ldap_uid_search);
if ($uid_result['count'] != 1) {
print "$li_warn The lastUID entry doesn't exist. ";
- print "What's this?";
print "";
@@ -187,8 +187,8 @@ else {
}
-$defgroup_filter = "(&(objectclass=posixGroup)(${LDAP['group_attribute']}=${DEFAULT_USER_GROUP}))";
-$ldap_defgroup_search = ldap_search($ldap_connection, "${LDAP['base_dn']}", $defgroup_filter);
+$defgroup_filter = "(&(objectclass=posixGroup)({$LDAP['group_attribute']}={$DEFAULT_USER_GROUP}))";
+$ldap_defgroup_search = ldap_search($ldap_connection, "{$LDAP['base_dn']}", $defgroup_filter);
$defgroup_result = ldap_get_entries($ldap_connection, $ldap_defgroup_search);
if ($defgroup_result['count'] != 1) {
@@ -207,15 +207,15 @@ else {
}
-$adminsgroup_filter = "(&(objectclass=posixGroup)(${LDAP['group_attribute']}=${LDAP['admins_group']}))";
-$ldap_adminsgroup_search = ldap_search($ldap_connection, "${LDAP['base_dn']}", $adminsgroup_filter);
+$adminsgroup_filter = "(&(objectclass=posixGroup)({$LDAP['group_attribute']}={$LDAP['admins_group']}))";
+$ldap_adminsgroup_search = ldap_search($ldap_connection, "{$LDAP['base_dn']}", $adminsgroup_filter);
$adminsgroup_result = ldap_get_entries($ldap_connection, $ldap_adminsgroup_search);
if ($adminsgroup_result['count'] != 1) {
- print "$li_fail The group defining LDAP account administrators (${LDAP['admins_group']}) doesn't exist. ";
+ print "$li_fail The group defining LDAP account administrators ({$LDAP['admins_group']}) doesn't exist. ";
print "What's this?";
print "";
print "\n";
@@ -223,7 +223,7 @@ if ($adminsgroup_result['count'] != 1) {
}
else {
- print "$li_good The LDAP account administrators group (${LDAP['admins_group']}) is present.";
+ print "$li_good The LDAP account administrators group ({$LDAP['admins_group']}) is present.";
$admins = ldap_get_group_members($ldap_connection,$LDAP['admins_group']);
@@ -249,7 +249,7 @@ if ($show_finish_button == TRUE) {
?>
-
diff --git a/www/setup/setup_ldap.php b/www/setup/setup_ldap.php
index 6011ed5..6430335 100644
--- a/www/setup/setup_ldap.php
+++ b/www/setup/setup_ldap.php
@@ -37,11 +37,11 @@ if (isset($_POST['fix_problems'])) {
if (isset($_POST['setup_group_ou'])) {
$ou_add = @ ldap_add($ldap_connection, $LDAP['group_dn'], array( 'objectClass' => 'organizationalUnit', 'ou' => $LDAP['group_ou'] ));
if ($ou_add == TRUE) {
- print "$li_good Created OU ${LDAP['group_dn']}\n";
+ print "$li_good Created OU {$LDAP['group_dn']}\n";
}
else {
$error = ldap_error($ldap_connection);
- print "$li_fail Couldn't create ${LDAP['group_dn']}:
$error
\n";
+ print "$li_fail Couldn't create {$LDAP['group_dn']}: $error
\n";
$no_errors = FALSE;
}
}
@@ -50,11 +50,11 @@ if (isset($_POST['fix_problems'])) {
if (isset($_POST['setup_user_ou'])) {
$ou_add = @ ldap_add($ldap_connection, $LDAP['user_dn'], array( 'objectClass' => 'organizationalUnit', 'ou' => $LDAP['user_ou'] ));
if ($ou_add == TRUE) {
- print "$li_good Created OU ${LDAP['user_dn']}\n";
+ print "$li_good Created OU {$LDAP['user_dn']}\n";
}
else {
$error = ldap_error($ldap_connection);
- print "$li_fail Couldn't create ${LDAP['user_dn']}: $error
\n";
+ print "$li_fail Couldn't create {$LDAP['user_dn']}: $error
\n";
$no_errors = FALSE;
}
}
@@ -69,14 +69,14 @@ if (isset($_POST['fix_problems'])) {
'serialnumber' => $highest_gid,
'description' => $description );
- $gid_add = @ ldap_add($ldap_connection, "cn=lastGID,${LDAP['base_dn']}", $add_lastgid_r);
+ $gid_add = @ ldap_add($ldap_connection, "cn=lastGID,{$LDAP['base_dn']}", $add_lastgid_r);
if ($gid_add == TRUE) {
- print "$li_good Created cn=lastGID,${LDAP['base_dn']}\n";
+ print "$li_good Created cn=lastGID,{$LDAP['base_dn']}\n";
}
else {
$error = ldap_error($ldap_connection);
- print "$li_fail Couldn't create cn=lastGID,${LDAP['base_dn']}: $error
\n";
+ print "$li_fail Couldn't create cn=lastGID,{$LDAP['base_dn']}: $error
\n";
$no_errors = FALSE;
}
}
@@ -91,14 +91,14 @@ if (isset($_POST['fix_problems'])) {
'serialnumber' => $highest_uid,
'description' => $description );
- $uid_add = @ ldap_add($ldap_connection, "cn=lastUID,${LDAP['base_dn']}", $add_lastuid_r);
+ $uid_add = @ ldap_add($ldap_connection, "cn=lastUID,{$LDAP['base_dn']}", $add_lastuid_r);
if ($uid_add == TRUE) {
- print "$li_good Created cn=lastUID,${LDAP['base_dn']}\n";
+ print "$li_good Created cn=lastUID,{$LDAP['base_dn']}\n";
}
else {
$error = ldap_error($ldap_connection);
- print "$li_fail Couldn't create cn=lastUID,${LDAP['base_dn']}: $error
\n";
+ print "$li_fail Couldn't create cn=lastUID,{$LDAP['base_dn']}: $error
\n";
$no_errors = FALSE;
}
}
@@ -123,7 +123,7 @@ if (isset($_POST['fix_problems'])) {
$group_add = ldap_new_group($ldap_connection,$LDAP['admins_group']);
if ($group_add == TRUE) {
- print "$li_good Created LDAP administrators group: ${LDAP['admins_group']}\n";
+ print "$li_good Created LDAP administrators group: {$LDAP['admins_group']}\n";
}
else {
$error = ldap_error($ldap_connection);
@@ -138,19 +138,19 @@ if (isset($_POST['fix_problems'])) {
?>
-