forked from HomeLab/unraid-mcp
37e9424a5c
Comprehensive fixes across Python code, shell scripts, and documentation addressing all remaining MEDIUM and LOW priority review comments. Python Code Fixes (27 fixes): - tools/info.py: Simplified dispatch with lookup tables, defensive guards, CPU fallback formatting, !s conversion flags, module-level sync assertion - tools/docker.py: Case-insensitive container ID regex, keyword-only confirm, module-level ALL_ACTIONS constant - tools/virtualization.py: Normalized single-VM dict responses, unified list/details queries - core/client.py: Fixed HTTP client singleton race condition, compound key substring matching for sensitive data redaction - subscriptions/: Extracted SSL context creation to shared helper in utils.py, replaced deprecated ssl._create_unverified_context API - tools/array.py: Renamed parity_history to parity_status, hoisted ALL_ACTIONS - tools/storage.py: Fixed dict(None) risks, temperature 0 falsiness bug - tools/notifications.py, keys.py, rclone.py: Fixed dict(None) TypeError risks - tests/: Fixed generator type annotations, added coverage for compound keys Shell Script Fixes (13 fixes): - dashboard.sh: Dynamic server discovery, conditional debug output, null-safe jq, notification count guard order, removed unused variables - unraid-query.sh: Proper JSON escaping via jq, --ignore-errors and --insecure CLI flags, TLS verification now on by default - validate-marketplace.sh: Removed unused YELLOW variable, defensive jq, simplified repository URL output Documentation Fixes (24+ fixes): - Version consistency: Updated all references to v0.2.0 across pyproject.toml, plugin.json, marketplace.json, MARKETPLACE.md, __init__.py, README files - Tool count updates: Changed all "26 tools" references to "10 tools, 90 actions" - Markdown lint: Fixed MD022, MD031, MD047 issues across multiple files - Research docs: Fixed auth headers, removed web artifacts, corrected stale info - Skills docs: Fixed query examples, endpoint counts, env var references All 227 tests pass, ruff and ty checks clean.
98 lines
3.8 KiB
Python
98 lines
3.8 KiB
Python
"""Tests for unraid_keys tool."""
|
|
|
|
from collections.abc import Generator
|
|
from unittest.mock import AsyncMock, patch
|
|
|
|
import pytest
|
|
from conftest import make_tool_fn
|
|
|
|
from unraid_mcp.core.exceptions import ToolError
|
|
|
|
|
|
@pytest.fixture
|
|
def _mock_graphql() -> Generator[AsyncMock, None, None]:
|
|
with patch("unraid_mcp.tools.keys.make_graphql_request", new_callable=AsyncMock) as mock:
|
|
yield mock
|
|
|
|
|
|
def _make_tool():
|
|
return make_tool_fn("unraid_mcp.tools.keys", "register_keys_tool", "unraid_keys")
|
|
|
|
|
|
class TestKeysValidation:
|
|
async def test_delete_requires_confirm(self, _mock_graphql: AsyncMock) -> None:
|
|
tool_fn = _make_tool()
|
|
with pytest.raises(ToolError, match="destructive"):
|
|
await tool_fn(action="delete", key_id="k:1")
|
|
|
|
async def test_get_requires_key_id(self, _mock_graphql: AsyncMock) -> None:
|
|
tool_fn = _make_tool()
|
|
with pytest.raises(ToolError, match="key_id"):
|
|
await tool_fn(action="get")
|
|
|
|
async def test_create_requires_name(self, _mock_graphql: AsyncMock) -> None:
|
|
tool_fn = _make_tool()
|
|
with pytest.raises(ToolError, match="name"):
|
|
await tool_fn(action="create")
|
|
|
|
async def test_update_requires_key_id(self, _mock_graphql: AsyncMock) -> None:
|
|
tool_fn = _make_tool()
|
|
with pytest.raises(ToolError, match="key_id"):
|
|
await tool_fn(action="update")
|
|
|
|
async def test_delete_requires_key_id(self, _mock_graphql: AsyncMock) -> None:
|
|
tool_fn = _make_tool()
|
|
with pytest.raises(ToolError, match="key_id"):
|
|
await tool_fn(action="delete", confirm=True)
|
|
|
|
|
|
class TestKeysActions:
|
|
async def test_list(self, _mock_graphql: AsyncMock) -> None:
|
|
_mock_graphql.return_value = {
|
|
"apiKeys": [{"id": "k:1", "name": "mcp-key", "roles": ["admin"]}]
|
|
}
|
|
tool_fn = _make_tool()
|
|
result = await tool_fn(action="list")
|
|
assert len(result["keys"]) == 1
|
|
|
|
async def test_get(self, _mock_graphql: AsyncMock) -> None:
|
|
_mock_graphql.return_value = {"apiKey": {"id": "k:1", "name": "mcp-key", "roles": ["admin"]}}
|
|
tool_fn = _make_tool()
|
|
result = await tool_fn(action="get", key_id="k:1")
|
|
assert result["name"] == "mcp-key"
|
|
|
|
async def test_create(self, _mock_graphql: AsyncMock) -> None:
|
|
_mock_graphql.return_value = {
|
|
"createApiKey": {"id": "k:new", "name": "new-key", "key": "secret123", "roles": []}
|
|
}
|
|
tool_fn = _make_tool()
|
|
result = await tool_fn(action="create", name="new-key")
|
|
assert result["success"] is True
|
|
assert result["key"]["name"] == "new-key"
|
|
|
|
async def test_create_with_roles(self, _mock_graphql: AsyncMock) -> None:
|
|
_mock_graphql.return_value = {
|
|
"createApiKey": {"id": "k:new", "name": "admin-key", "key": "secret", "roles": ["admin"]}
|
|
}
|
|
tool_fn = _make_tool()
|
|
result = await tool_fn(action="create", name="admin-key", roles=["admin"])
|
|
assert result["success"] is True
|
|
|
|
async def test_update(self, _mock_graphql: AsyncMock) -> None:
|
|
_mock_graphql.return_value = {"updateApiKey": {"id": "k:1", "name": "renamed", "roles": []}}
|
|
tool_fn = _make_tool()
|
|
result = await tool_fn(action="update", key_id="k:1", name="renamed")
|
|
assert result["success"] is True
|
|
|
|
async def test_delete(self, _mock_graphql: AsyncMock) -> None:
|
|
_mock_graphql.return_value = {"deleteApiKeys": True}
|
|
tool_fn = _make_tool()
|
|
result = await tool_fn(action="delete", key_id="k:1", confirm=True)
|
|
assert result["success"] is True
|
|
|
|
async def test_generic_exception_wraps(self, _mock_graphql: AsyncMock) -> None:
|
|
_mock_graphql.side_effect = RuntimeError("connection lost")
|
|
tool_fn = _make_tool()
|
|
with pytest.raises(ToolError, match="connection lost"):
|
|
await tool_fn(action="list")
|