fix: address PR review critical and high findings

- Remove duplicate _cap_log_content definition (dead code merge artifact)
  from manager.py; keep byte-count version that correctly handles multibyte UTF-8
- Fix storage.py unassigned handler reading wrong key (unassignedDevices → disks)
  — query already fetched `disks {}` but handler returned empty list every call
- Add null checks to all 8 Docker organizer object mutations; raise ToolError
  instead of silently returning success=True with organizer=None
- Raise ToolError in docker logs when server returns no log data
- Extract notification object from create response (was returning raw GraphQL
  wrapper dict instead of the notification itself)
- Raise ToolError in test_subscription_query on connection failure and unexpected
  exceptions (was returning error dicts, bypassing error handling)
- Remove stale "Bug N fix" inline comments from diagnostics.py
- Update docker.py module docstring to reflect 26 actions (was 15)
- Bump version 0.4.1 → 0.4.2

Co-authored-by: Claude <claude@anthropic.com>

unraid_mcp/subscriptions/diagnostics.py

@@ -101,13 +101,11 @@ def register_diagnostic_tools(mcp: FastMCP) -> None:
         Returns:
             Dict containing test results and response data
         """
-        # Validate before any network I/O (Bug 1 fix)
         field_name = _validate_subscription_query(subscription_query)
 
         try:
             logger.info(f"[TEST_SUBSCRIPTION] Testing validated subscription field '{field_name}'")
 
-            # Build WebSocket URL — raises ValueError on invalid/missing scheme (Bug 4 fix)
             try:
                 ws_url = build_ws_url()
             except ValueError as e:
@@ -139,7 +137,7 @@ def register_diagnostic_tools(mcp: FastMCP) -> None:
                 init_response = json.loads(response)
 
                 if init_response.get("type") != "connection_ack":
-                    return {"error": f"Connection failed: {init_response}"}
+                    raise ToolError(f"Connection failed: {init_response}")
 
                 # Send subscription
                 await websocket.send(
@@ -168,7 +166,7 @@ def register_diagnostic_tools(mcp: FastMCP) -> None:
             raise
         except Exception as e:
             logger.error(f"[TEST_SUBSCRIPTION] Error: {e}", exc_info=True)
-            return {"error": str(e), "query_tested": subscription_query}
+            raise ToolError(f"Subscription test failed: {e!s}") from e
 
     @mcp.tool()
     async def diagnose_subscriptions() -> dict[str, Any]:

unraid_mcp/subscriptions/manager.py

@@ -29,56 +29,6 @@ _MAX_RESOURCE_DATA_LINES = 5_000
 _STABLE_CONNECTION_SECONDS = 30
 
 
-def _cap_log_content(data: dict[str, Any]) -> dict[str, Any]:
-    """Cap log content in subscription data to prevent unbounded memory growth.
-
-    Returns a new dict — does NOT mutate the input. If any nested 'content'
-    field (from log subscriptions) exceeds the byte limit, truncate it to the
-    most recent _MAX_RESOURCE_DATA_LINES lines.
-
-    The final content is guaranteed to be <= _MAX_RESOURCE_DATA_BYTES.
-    """
-    result: dict[str, Any] = {}
-    for key, value in data.items():
-        if isinstance(value, dict):
-            result[key] = _cap_log_content(value)
-        elif (
-            key == "content"
-            and isinstance(value, str)
-            and len(value) > _MAX_RESOURCE_DATA_BYTES  # fast pre-check on char count
-        ):
-            lines = value.splitlines()
-            original_line_count = len(lines)
-
-            # Keep most recent lines first.
-            if len(lines) > _MAX_RESOURCE_DATA_LINES:
-                lines = lines[-_MAX_RESOURCE_DATA_LINES:]
-
-            truncated = "\n".join(lines)
-            # Encode once and slice bytes instead of O(n²) line-trim loop
-            encoded = truncated.encode("utf-8", errors="replace")
-            if len(encoded) > _MAX_RESOURCE_DATA_BYTES:
-                truncated = encoded[-_MAX_RESOURCE_DATA_BYTES:].decode("utf-8", errors="ignore")
-                # Strip partial first line that may have been cut mid-character
-                nl_pos = truncated.find("\n")
-                if nl_pos != -1:
-                    truncated = truncated[nl_pos + 1 :]
-
-            logger.warning(
-                f"[RESOURCE] Capped log content from {original_line_count} to "
-                f"{len(lines)} lines ({len(value)} -> {len(truncated)} chars)"
-            )
-            result[key] = truncated
-        else:
-            result[key] = value
-    return result
-
-
-# Resource data size limits to prevent unbounded memory growth
-_MAX_RESOURCE_DATA_BYTES = 1_048_576  # 1 MB
-_MAX_RESOURCE_DATA_LINES = 5_000
-
-
 def _cap_log_content(data: dict[str, Any]) -> dict[str, Any]:
     """Cap log content in subscription data to prevent unbounded memory growth.