forked from HomeLab/unraid-mcp
fix: address 54 MEDIUM/LOW priority PR review issues
Comprehensive fixes across Python code, shell scripts, and documentation addressing all remaining MEDIUM and LOW priority review comments. Python Code Fixes (27 fixes): - tools/info.py: Simplified dispatch with lookup tables, defensive guards, CPU fallback formatting, !s conversion flags, module-level sync assertion - tools/docker.py: Case-insensitive container ID regex, keyword-only confirm, module-level ALL_ACTIONS constant - tools/virtualization.py: Normalized single-VM dict responses, unified list/details queries - core/client.py: Fixed HTTP client singleton race condition, compound key substring matching for sensitive data redaction - subscriptions/: Extracted SSL context creation to shared helper in utils.py, replaced deprecated ssl._create_unverified_context API - tools/array.py: Renamed parity_history to parity_status, hoisted ALL_ACTIONS - tools/storage.py: Fixed dict(None) risks, temperature 0 falsiness bug - tools/notifications.py, keys.py, rclone.py: Fixed dict(None) TypeError risks - tests/: Fixed generator type annotations, added coverage for compound keys Shell Script Fixes (13 fixes): - dashboard.sh: Dynamic server discovery, conditional debug output, null-safe jq, notification count guard order, removed unused variables - unraid-query.sh: Proper JSON escaping via jq, --ignore-errors and --insecure CLI flags, TLS verification now on by default - validate-marketplace.sh: Removed unused YELLOW variable, defensive jq, simplified repository URL output Documentation Fixes (24+ fixes): - Version consistency: Updated all references to v0.2.0 across pyproject.toml, plugin.json, marketplace.json, MARKETPLACE.md, __init__.py, README files - Tool count updates: Changed all "26 tools" references to "10 tools, 90 actions" - Markdown lint: Fixed MD022, MD031, MD047 issues across multiple files - Research docs: Fixed auth headers, removed web artifacts, corrected stale info - Skills docs: Fixed query examples, endpoint counts, env var references All 227 tests pass, ruff and ty checks clean.
This commit is contained in:
21
CLAUDE.md
21
CLAUDE.md
@@ -21,23 +21,18 @@ uv sync --group dev
|
||||
# Local development with uv (recommended)
|
||||
uv run unraid-mcp-server
|
||||
|
||||
# Using development script with hot reload
|
||||
./dev.sh
|
||||
|
||||
# Direct module execution
|
||||
uv run -m unraid_mcp.main
|
||||
```
|
||||
|
||||
### Code Quality
|
||||
```bash
|
||||
# Format code with black
|
||||
uv run black unraid_mcp/
|
||||
|
||||
# Lint with ruff
|
||||
# Lint and format with ruff
|
||||
uv run ruff check unraid_mcp/
|
||||
uv run ruff format unraid_mcp/
|
||||
|
||||
# Type checking with mypy
|
||||
uv run mypy unraid_mcp/
|
||||
# Type checking with ty (Astral's fast type checker)
|
||||
uv run ty check unraid_mcp/
|
||||
|
||||
# Run tests
|
||||
uv run pytest
|
||||
@@ -49,13 +44,13 @@ uv run pytest
|
||||
docker build -t unraid-mcp-server .
|
||||
|
||||
# Run with Docker Compose
|
||||
docker-compose up -d
|
||||
docker compose up -d
|
||||
|
||||
# View logs
|
||||
docker-compose logs -f unraid-mcp
|
||||
docker compose logs -f unraid-mcp
|
||||
|
||||
# Stop service
|
||||
docker-compose down
|
||||
docker compose down
|
||||
```
|
||||
|
||||
### Environment Setup
|
||||
@@ -123,4 +118,4 @@ The server loads environment variables from multiple locations in order:
|
||||
- Increased timeouts for disk operations (90s read timeout)
|
||||
- Selective queries to avoid GraphQL type overflow issues
|
||||
- Optional caching controls for Docker container queries
|
||||
- Log file overwrite at 10MB cap to prevent disk space issues
|
||||
- Log file overwrite at 10MB cap to prevent disk space issues
|
||||
|
||||
Reference in New Issue
Block a user